Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vazir Font in Sass #24

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Vazir Font in Sass #24

merged 1 commit into from
Jan 11, 2017

Conversation

jaavid
Copy link
Contributor

@jaavid jaavid commented Jan 10, 2017

set up sass for ionic
add Vazir font in ionic sass files
override ionic sass variable to use vazir font

@ShalbafZadeh
Copy link
Contributor

ShalbafZadeh commented Jan 10, 2017

@jaavid is there any duplication between this pull request and #23 ?
i think one this pull requests could be merged
cc:@bobsilon

@bobsilon
Copy link

@ShalbafZadeh Yes both the same I think, The only difference is their method of implementation.
@jaavid uses ionic setup sass. And the other uses gulpjs to create styles based on scss files.
One should be merged.

@jadijadi
Copy link
Owner

@ShalbafZadeh @jaavid @bobsilon thanks all for discussing the issue. I'll go with ionic setup sass solution.

@jadijadi jadijadi merged commit e631d48 into jadijadi:master Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants