Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery dependency #81

Open
jadrake75 opened this issue Jan 5, 2015 · 3 comments
Open

Remove jQuery dependency #81

jadrake75 opened this issue Jan 5, 2015 · 3 comments
Milestone

Comments

@jadrake75
Copy link
Owner

For the most part jQuery is being used for selectors. While it is not the end of the world, it would be nice to not have to have a jQuery dependency on the library

@Xanir
Copy link
Collaborator

Xanir commented Jan 5, 2015

A quick and easy fix for this would be to replace the follow regex searches:

$((.+?))
and
jQuery((.+?))

with
document[0].body.querySelector($1)

@jadrake75
Copy link
Owner Author

My understand though is that querySelector does not support 100% of the
selectors used by jQuery. We are also using attr( ) if memory serves and
some of the addClass/removeClass methods. Again nothing that can not be
done easily in HTML-5 evergreen browsers using modern JS but still some
effort to do it. I think it starts with an assessment of where the impacts
are and how to address them.

On Mon, Jan 5, 2015 at 1:30 PM, Xanir notifications@github.com wrote:

A quick and easy fix for this would be to replace the follow regex
searches:

$((.+?))
and
jQuery((.+?))

with
document[0].body.querySelector($1)


Reply to this email directly or view it on GitHub
#81 (comment)
.

@Xanir
Copy link
Collaborator

Xanir commented Jan 5, 2015

Correct that querySelector does not support all jQuery selectors but it does support all CSS selectors.
angular.element, without jQuery installed also supports addClass/removeClass and the attr function.

@jadrake75 jadrake75 modified the milestone: 0.9.1 Jan 12, 2015
@jadrake75 jadrake75 modified the milestone: 0.9.1 Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants