Grunt W3C Validation #470

nvasileiadis · 2017-01-24T00:41:50Z

The validation of the project's output markup HTML with W3C standards validator has been added to and updated the Grunt workflow.

This helps to maintain an updated bundle of dependencies among different branches, devs and machines.

This folder will contain any errors, in a formated and timestamped way, after the grunt is run.

Those two files added are containing a raw output of the validation run and are overwritten every time.

nvasileiadis · 2017-01-24T00:42:32Z

There is a need for a directories check and addition if anything is missing.

codecov-io · 2017-01-24T00:49:06Z

Codecov Report

Merging #470 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #470      +/-   ##
===========================================
- Coverage     98.4%   98.36%   -0.05%     
===========================================
  Files           16       15       -1     
  Lines          627      611      -16     
===========================================
- Hits           617      601      -16     
  Misses          10       10

Impacted Files	Coverage Δ
js/DisableUiComponent.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a72a5d...eb9e212. Read the comment docs.

Stanton · 2017-01-24T08:49:46Z

Gruntfile.js

+            },
+            files: {
+                src: ['dist/views/*.html', 
+                                'emails/dist/*.html', 


Tabbing looks a bit odd here

Stanton · 2017-01-24T08:50:02Z

Gruntfile.js

+                reset: grunt.option('reset') || false,
+                stoponerror: false,
+                maxTry: 3,
+                relaxerror: ['Bad value X-UA-Compatible for attribute http-equiv on element meta.'], //ignores these errors 


Minor point, but need space after //

Stanton · 2017-01-24T08:52:00Z

.gitignore

@@ -26,3 +26,5 @@ pulsar.zip
 /fonts/_config.fonts.scss

 /.csscomb.json
+/validation-status.json


These files will also need adding to the .gitattributes file as export-ignore rules so that Continuum products can ignore them

Stanton · 2017-01-24T08:53:33Z

Gruntfile.js

+                generateReport: true,
+                errorHTMLRootDir: "w3cErrorFolder",
+                useTimeStamp: true,
+                errorTemplate: "w3cErrorFolder/w3c_validation_error_Template.html"


This might be more appropriate to put in the /tests directory, /tests/validation perhaps?

Relocated as advised

Stanton · 2017-01-24T08:54:29Z

Gruntfile.js

+                maxTry: 3,
+                relaxerror: ['Bad value X-UA-Compatible for attribute http-equiv on element meta.'], //ignores these errors 
+                generateReport: true,
+                errorHTMLRootDir: "w3cErrorFolder",


Wherever the output is placed, we'll need to add it to the .gitignore file so it's not committed to the repository

Stanton · 2017-01-24T08:55:41Z

Gruntfile.js

@@ -494,16 +513,19 @@ module.exports = function(grunt) {
        ]
    });

+    grunt.loadNpmTasks('grunt-w3c-html-validation');


Shouldn't need this, it's handled by matchdep at the bottom of the gruntfile

Stanton · 2017-01-24T08:55:46Z

Gruntfile.js

@@ -494,16 +513,19 @@ module.exports = function(grunt) {
        ]
    });

+    grunt.loadNpmTasks('grunt-w3c-html-validation');
+
    grunt.registerTask('default', [


How long does the validation task take? Is it something we want to run on the default task, or something to roll into a testing/pre-release task?

It takes some time, moved from default to separate task. Can be run with 'grunt validate' at will

This is for W3C Validation grunt task.

The file produced and the directory used by W3C Validation.

Changes: 1. Move error reports directory and template to /tests/validation 2. Correct indentation and spacing 3. Remove obsolete loadNpmTasks 4. Make ‘validate’ a separate task

Changed the gitingore and gitattibutes to include only the folders and files generated after the task run. The previous settings were ignoring the error template.

Stanton

Couple of new things now I've had chance to check out and run the task.

Stanton · 2017-01-26T13:34:48Z

Gruntfile.js

+            },
+            files: {
+                src: ['dist/views/*.html', 
+                    'emails/dist/*.html', 


On second thoughts I don't think validating emails is much use as most of this is automatically generated based on email client quirks.

Emails have been removed from the related settings in gruntfile.

Stanton · 2017-01-26T13:35:53Z

Gruntfile.js

+                errorTemplate: "tests/validation/w3c_validation_error_Template.html"
+            },
+            files: {
+                src: ['dist/views/*.html', 


I think we should list the relevant lexicon urls we'd want to validate rather than just the .html files e have in /dist, this will let us validate against our Twig output.

Do you mean /dist/views/pulsar? Because all the other files I see are assets. If this is the only folder with the html and twig parts I will change and commit it.

# Conflicts: # Gruntfile.js

houndci-bot · 2017-03-29T13:29:22Z

js/casper.js

+    fs.write('dist/htmloutput/page.html', this.getPageContent(), 'w');
+});
+
+casper.run(function() {


'casper' is not defined.

houndci-bot · 2017-03-29T13:29:22Z

js/casper.js

@@ -0,0 +1,9 @@
+var fs = require('fs');
+
+casper.start('http://google.com', function() {


'casper' is not defined.

houndci-bot · 2017-03-29T13:29:22Z

js/casper.js

+
+casper.run(function() {
+    this.exit();
+})


Missing semicolon.

houndci-bot · 2017-03-29T13:29:22Z

js/casper.js

+});
+
+casper.run(function() {
+    this.exit();


Missing "use strict" statement.

houndci-bot · 2017-03-29T13:29:22Z

js/casper.js

+var fs = require('fs');
+
+casper.start('http://google.com', function() {
+    fs.write('dist/htmloutput/page.html', this.getPageContent(), 'w');


Missing "use strict" statement.

Now it should output properly different report for each page.

houndci-bot · 2017-04-12T08:54:37Z

js/casper.js

+
+    for (;current < end;) {
+        (function(cntr) {
+            casper.thenOpen('http://192.168.13.37/' + links[cntr] + '', function() {


'casper' is not defined.

houndci-bot · 2017-04-12T08:54:37Z

js/casper.js

+    var end = links.length;
+
+    for (;current < end;) {
+        (function(cntr) {


Don't make functions within a loop.

houndci-bot · 2017-05-12T16:06:10Z

js/casper.js

+
+    for (;current < end;) {
+        (function(cntr) {
+            casper.thenOpen('http://192.168.13.37/' + links[cntr] + '', function() {


'casper' is not defined.

houndci-bot · 2017-05-12T16:06:10Z

js/casper.js

+
+    // Get Page Name from URL
+    for (var i = 0; i < links.length; i++) {
+        if (links[i].match(regex) != null ) { // Remove null items that didn't pass the regex


Expected '!==' and instead saw '!='.

houndci-bot · 2017-05-12T21:32:07Z

js/casper.js

+
+    // Get Page Name from URL
+    for (var i = 0; i < newlinks.length; i++) {
+        if (newlinks[i].match(regex) != null ) { // Remove null items that didn't pass the regex


Expected '!==' and instead saw '!='.

This could be simplified further to if (newlinks[i].match(regex )) as we'll get an array with the matching regex query if we've got a match, this will also keep the hound at bay.

houndci-bot · 2017-05-12T21:32:07Z

js/casper.js

+    };
+
+    // Get Page Name from URL
+    for (var i = 0; i < newlinks.length; i++) {


'i' is already defined.

houndci-bot · 2017-05-12T21:32:07Z

js/casper.js

+        if (links[i].indexOf('#')  == -1) {
+            newlinks.push(links[i]);
+        };
+    };


Unnecessary semicolon.

houndci-bot · 2017-05-12T21:32:07Z

js/casper.js

+    for (var i = 0; i < links.length; i++) {
+        if (links[i].indexOf('#')  == -1) {
+            newlinks.push(links[i]);
+        };


Unnecessary semicolon.

houndci-bot · 2017-05-12T21:32:07Z

js/casper.js

+
+    // Remove links within the same page
+    for (var i = 0; i < links.length; i++) {
+        if (links[i].indexOf('#')  == -1) {


Expected '===' and instead saw '=='.

There's also an extra space before ==, I agree with the hound on this one, always best to be explicit with operators.

An extra '=' was added

Changes Made

…into grunt-w3c-validation

nvasileiadis · 2017-05-16T09:42:14Z

Closes #469

nvasileiadis · 2017-05-16T09:51:36Z

Closes #469

nvasileiadis added 4 commits January 24, 2017 00:28

Add W3C Validation Dependency to package.json

2a66569

This helps to maintain an updated bundle of dependencies among different branches, devs and machines.

Add Error Keeping Directory & Error Output Template

ebbad57

This folder will contain any errors, in a formated and timestamped way, after the grunt is run.

Update gitignore for Validation related files

2836afd

Those two files added are containing a raw output of the validation run and are overwritten every time.

Update Gruntfile to run with W3C Validation

c559ea6

nvasileiadis added the awaiting review label Jan 24, 2017

nvasileiadis requested review from Stanton and jamesjacobs January 24, 2017 00:41

nvasileiadis self-assigned this Jan 24, 2017

Stanton requested changes Jan 24, 2017

View reviewed changes

Stanton added the tooling label Jan 24, 2017

nvasileiadis added 5 commits January 26, 2017 00:24

Relocate File to /tests/validation

d1b69d4

Update gitignore to bypass tests/validation

40f354a

This is for W3C Validation grunt task.

Add directories to gitattributes

ec65bb1

The file produced and the directory used by W3C Validation.

Update Gruntfile for W3C Validation

cf1e835

Changes: 1. Move error reports directory and template to /tests/validation 2. Correct indentation and spacing 3. Remove obsolete loadNpmTasks 4. Make ‘validate’ a separate task

Update ignore to include only newly generated folders

b426b6e

Changed the gitingore and gitattibutes to include only the folders and files generated after the task run. The previous settings were ignoring the error template.

Stanton previously requested changes Jan 26, 2017

View reviewed changes

Stanton removed the awaiting review label Jan 26, 2017

Remove Email Related Folders from Validate Task

cf08416

nvasileiadis added the awaiting review label Feb 1, 2017

nvasileiadis added 🚫 blocked and removed awaiting review labels Feb 27, 2017

nvasileiadis added 2 commits March 27, 2017 13:16

Merge branch 'develop' into grunt-w3c-validation

a735d0a

# Conflicts: # Gruntfile.js

Add Casper JS File

9fc1d78

houndci-bot reviewed Mar 29, 2017

View reviewed changes

nvasileiadis added 4 commits March 29, 2017 14:53

Add CasperJS Dependency to the Project

6ab3c56

Add New Folder Structure to gitignore

713c2a3

Add CasperJS to Gruntfile

9e8b909

Add CasperJS Browsing Steps

d094ad7

nvasileiadis requested a review from mikedevelops April 11, 2017 15:31

Resolve Duplicate HTML Outputs Issue

0658792

Now it should output properly different report for each page.

houndci-bot reviewed Apr 12, 2017

View reviewed changes

Stanton removed the awaiting review label Apr 26, 2017

Add Filter of URL Names for Use in Output Files

07e3581

houndci-bot reviewed May 12, 2017

View reviewed changes

Fix Output File Names to Match the URLs

1719aa0

houndci-bot reviewed May 12, 2017

View reviewed changes

nvasileiadis added 5 commits May 12, 2017 22:46

Merge branch 'develop' into grunt-w3c-validation

9357087

Improve Report File Name Title Readability

9b1f768

Merge branch 'grunt-w3c-validation' of https://github.com/jadu/pulsar …

c38c0fd

…into grunt-w3c-validation

Refactoring Based on Peer Review and Hound

81e8e44

Improve Index Output Naming

eb9e212

mikedevelops approved these changes May 16, 2017

View reviewed changes

nvasileiadis closed this May 16, 2017

nvasileiadis reopened this May 16, 2017

nvasileiadis merged commit 555b3f4 into develop May 16, 2017

nvasileiadis deleted the grunt-w3c-validation branch May 16, 2017 09:51

nvasileiadis restored the grunt-w3c-validation branch May 16, 2017 10:04

jadu deleted a comment from houndci-bot Oct 23, 2017

		@@ -0,0 +1,9 @@
		var fs = require('fs');

		casper.start('http://google.com', function() {

Grunt W3C Validation #470

Grunt W3C Validation #470

Conversation

nvasileiadis commented Jan 24, 2017

nvasileiadis commented Jan 24, 2017

codecov-io commented Jan 24, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nvasileiadis Jan 26, 2017 • edited Loading

Choose a reason for hiding this comment

Stanton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nvasileiadis commented May 16, 2017

nvasileiadis commented May 16, 2017

codecov-io commented Jan 24, 2017 •

edited

Loading

nvasileiadis Jan 26, 2017 •

edited

Loading