Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty values #79

Merged
merged 2 commits into from
May 7, 2019
Merged

Fix empty values #79

merged 2 commits into from
May 7, 2019

Conversation

jaebradley
Copy link
Owner

@jaebradley jaebradley commented May 7, 2019

Closes #78.

Adds helper methods to convert string values to int and floats to handle cases where Basketball Reference accidentally has an empty or blank value for a numerical field.

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #79 into v4 will increase coverage by 1.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              v4      #79      +/-   ##
=========================================
+ Coverage   92.5%   93.51%   +1.01%     
=========================================
  Files         12       13       +1     
  Lines        307      324      +17     
  Branches      38       39       +1     
=========================================
+ Hits         284      303      +19     
+ Misses        19       18       -1     
+ Partials       4        3       -1
Impacted Files Coverage Δ
basketball_reference_web_scraper/utilities.py 100% <100%> (ø)
...sketball_reference_web_scraper/parsers/schedule.py 100% <100%> (+5.88%) ⬆️
..._reference_web_scraper/parsers/box_scores/teams.py 100% <100%> (ø) ⬆️
...eference_web_scraper/parsers/box_scores/players.py 100% <100%> (ø) ⬆️
...rence_web_scraper/parsers/players_season_totals.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14c6be...9ec96d0. Read the comment docs.

@jaebradley jaebradley merged commit 2f7ce42 into v4 May 7, 2019
@jaebradley jaebradley deleted the fix-empty-values branch May 7, 2019 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default values when parsing to handle cases where text content doesn't exist or is empty string
1 participant