Fix hiding disabled snapcast section in responsive mode #858
+442
−413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In responsive mode, the snapcast section takes a lot of space for nothing when it is disabled. I noticed there was already an intent to hide it, as
_output-control.scss
had adisplay: none
for that, unfortunately it was not targeting the correct class. And also, there was a remaining issue of background still taking the space due to absolute positioning.So this PR:
Use flex column rather than absolute position in responsive controls
The absolute positioning was making it hard to hide the snapcast section
in responsive mode.
For flex columns, needed to add enclosing sections in DOM structure