Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hiding disabled snapcast section in responsive mode #858

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jotak
Copy link
Contributor

@jotak jotak commented Aug 7, 2022

In responsive mode, the snapcast section takes a lot of space for nothing when it is disabled. I noticed there was already an intent to hide it, as _output-control.scss had a display: none for that, unfortunately it was not targeting the correct class. And also, there was a remaining issue of background still taking the space due to absolute positioning.

So this PR:

  • Use flex column rather than absolute position in responsive controls
    The absolute positioning was making it hard to hide the snapcast section
    in responsive mode.

  • For flex columns, needed to add enclosing sections in DOM structure

Use flex column rather than absolute position in responsive controls
The absolute positioning was making it hard to hide the snapcast section
in responsive mode.
@jotak
Copy link
Contributor Author

jotak commented Aug 7, 2022

(tips: hide whitespaces while reviewing ... the diff is much easier to read)

@jotak
Copy link
Contributor Author

jotak commented Aug 7, 2022

Hey @jaedb ,
I hope this PR is ok with you.
I added a second commit with the built files, I don't know if you expect them to be part of the commits, or if it's anyway overwritten during releases or something...

Also: I'm not really a css guy, please let me know if something is done wrong.
Since I'm new to mopidy I haven't fully understood yet what's snapcast and how it works, so I haven't tested my PR when it's enabled. That's surely something to do.

Also, is there a chat channel for Iris? On mopidy's zulip maybe? I'd be interested in contributing more if that's ok, maybe, however there's a couple of things I have some trouble with, like the dev mode...

jaedb added a commit that referenced this pull request Feb 19, 2023
- When snapcast is not enabled AND
- When no controls saved
- Supercedes PR #858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant