Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #29

Closed
wants to merge 8 commits into from
Closed

Update dependencies #29

wants to merge 8 commits into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 5, 2023

Summary

Update Alpine to 3.18
Update Golang to 1.21.3
Update grpc to 1.50.0
Update grpc-gateway to 2.18.0
Add protoc-gen-go-grpc 1.3.0
Update actions/checkout to v4
Update upx to 4.2.1
Update protoc-gen-lint to 0.3.0

Changes

  • protoc-gen-swagger is replaced by protoc-gen-openapiv2 so the arg swagger_out is replaced by openapiv2_opt

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 changed the title Update grpc-gateway to 2.15.2 and add protoc-gen-go-grpc 1.3.0 Update dependencies Nov 5, 2023
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as draft November 5, 2023 22:54
@mmorel-35 mmorel-35 marked this pull request as ready for review November 6, 2023 07:16
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Nov 6, 2023

Hi @yurishkuro ,
This is compiling with grpc 1.50.
I tried 1.59 and 1.55 which are both failing to compile after 1h11.
Can we keep this upgrades for later and get a release with this version ?

@yurishkuro
Copy link
Member

I think we need to add the jaeger-idl repo (or even main jaeger) as a submodule and run a build there as part of the CI in this repo. Otherwise it's very hard to verify that the changes are not breaking something when compiling the IDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants