Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List all storage backends are currently supported for adaptive sampling #676

Closed
wants to merge 1 commit into from
Closed

List all storage backends are currently supported for adaptive sampling #676

wants to merge 1 commit into from

Conversation

Pushkarm029
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • I have updated the document to include information about storage backends that support sampling.

Checklist

@Pushkarm029
fix doc
a097f83 
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Mar 3, 2024 •
edited
Loading

✅ Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit a097f83
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/65e44b037b47e700087e9d8d
😎 Deploy Preview https://deploy-preview-676--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yurishkuro
yurishkuro reviewed Mar 3, 2024
View reviewed changes
content/docs/next-release/sampling.md
@@ -92,7 +92,7 @@ Since Jaeger v1.27.

Adaptive sampling works in **jaeger-collector** by observing the spans received from services and recalculating sampling probabilities for each service/endpoint combination to ensure that the volume of collected traces matches `--sampling.target-samples-per-second`. When a new service or endpoint is detected, it is initially sampled with `--sampling.initial-sampling-probability` until enough data is collected to calculate the rate appropriate for the traffic going through the endpoint.

Adaptive sampling requires a storage backend to store the observed traffic data and computed probabilities. At the moment `memory` (for all-in-one deployment) and `cassandra` are supported as sampling storage backends. We are seeking help in implementing support for other backends ([tracking issue](https://github.com/jaegertracing/jaeger/issues/3305)).
Adaptive sampling requires a storage backend to store the observed traffic data and computed probabilities. At the moment `memory` (for all-in-one deployment), `cassandra`, `badger` and `elasticsearch` are supported as sampling storage backends.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since elasticsearch and opensearch are currently implemented with the same plugin in Jaeger, does this mean opensearch can also be used for adaptive sampling?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so because when adaptive sampling was messed up, integration tests failed for both open search and elastic search. So, we can conclude that adaptive sampling will also work with OpenSearch.

If you agree too, we will add it here(in docs), also

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - we don't have specific opensearch code in plugin/storage/integration which means it's working for it too

@yurishkuro yurishkuro changed the title update doc to include information about which storage backends are currently supported. List all storage backends are currently supported for adaptive sampling Mar 3, 2024
@yurishkuro yurishkuro mentioned this pull request Mar 3, 2024
Open
6 tasks
@yurishkuro yurishkuro mentioned this pull request Mar 20, 2024
Merged
@yurishkuro
Copy link
Member

Cannot amend PR from fork/main, resubmitted as #688

@yurishkuro yurishkuro closed this Mar 20, 2024
yurishkuro added a commit that referenced this pull request Mar 20, 2024
@yurishkuro @Pushkarm029
List all storage backends are currently supported for adaptive sampli…
562fba4 
…ng (#688)

Replaces #676

---------

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Pushkar Mishra <pushkarmishra029@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pushkarm029 @yurishkuro