[Jaeger] fix .allinone.replicas helm value #499
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug created after PR#494 when helm chart value
.allInOne.replicas
is0
but the deployment is still set to 1.When the below if statement is computed for
replicas: 0
, the result isfalse
and as a consequence the deployment manifest doesn't containreplicas
field, which in turn forces it to use the default value, which is1
.replicas
, we can check if.allInOne.replicas
key has been declared. This would create a deployment with the specified number of replicas in the values file.Checklist
[jaeger]
or[jaeger-operator]
)