This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add debug logs #504
Merged
Add debug logs #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Log tracer and reporter closes - Log samplers on updates to sampling strategies Signed-off-by: Prithvi Raj <p.r@uber.com>
vprithvi
commented
Apr 22, 2020
| @@ -200,6 +200,7 @@ func (s *RemotelyControlledSampler) updateSamplerViaUpdaters(strategy interface{ | |||
| return err | |||
| } | |||
| if sampler != nil { | |||
| s.logger.Debugf("sampler updated: %+v", sampler) | |||
There was a problem hiding this comment.
The logger is a debug logger - the stringer on sampler won't be called unless the log level is set to debug. The default poll interval is 1 minute.
yurishkuro
approved these changes
Apr 22, 2020
Signed-off-by: Prithvi Raj <p.r@uber.com>
Signed-off-by: Prithvi Raj <p.r@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 88.68% 88.73% +0.05%
==========================================
Files 60 60
Lines 3764 3782 +18
==========================================
+ Hits 3338 3356 +18
Misses 309 309
Partials 117 117
Continue to review full report at Codecov.
|
|
Please add unit tests invoking the new ToString method to increase code coverage. |
Signed-off-by: Prithvi Raj <p.r@uber.com>
Signed-off-by: Prithvi Raj <p.r@uber.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #501
Signed-off-by: Prithvi Raj p.r@uber.com