Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing release v1.34.0 #1884

Merged
merged 1 commit into from
May 17, 2022
Merged

Preparing release v1.34.0 #1884

merged 1 commit into from
May 17, 2022

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented May 12, 2022 •
edited
Loading

Signed-off-by: Benedikt Bongartz bongartz@klimlive.de

blocked by #1702, #1891

Closes #1879

@codecov
Copy link

codecov bot commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #1884 (873bb99) into main (d1e725b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1884   +/-   ##
=======================================
  Coverage   88.11%   88.11%           
=======================================
  Files         100      100           
  Lines        6303     6303           
=======================================
  Hits         5554     5554           
  Misses        551      551           
  Partials      198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e725b...873bb99. Read the comment docs.

frzifus
frzifus commented May 13, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@frzifus frzifus force-pushed the prepare-1.34.0 branch 2 times, most recently from 110e4fd to a313a24 Compare May 13, 2022 15:30
@frzifus
Copy link
Member Author

frzifus commented May 15, 2022 •
edited
Loading

mh.. streaming/streaming_with_tls FAILED, flaky?

@frzifus frzifus force-pushed the prepare-1.34.0 branch 2 times, most recently from e6c7343 to 5fbec6c Compare May 15, 2022 21:18
@frzifus
Copy link
Member Author

frzifus commented May 16, 2022

tried it locally with this and the main branch.

FAIL
+-------------------------------------------+--------+
|                   NAME                    | RESULT |
+-------------------------------------------+--------+
| streaming/streaming_with_tls              | failed |
| streaming/streaming_with_autoprovisioning | passed |
| streaming/streaming_simple                | failed |
+-------------------------------------------+--------+

@frzifus frzifus mentioned this pull request May 17, 2022
Closed
@frzifus frzifus changed the title Preparing release v1.34.0 Preparing release v1.34.1 May 17, 2022
@frzifus
Preparing release v1.34.0
873bb99 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus frzifus changed the title Preparing release v1.34.1 Preparing release v1.34.0 May 17, 2022
@rubenvp8510 rubenvp8510 enabled auto-merge (squash) May 17, 2022 22:48
@rubenvp8510 rubenvp8510 merged commit 98aa7eb into jaegertracing:main May 17, 2022
@frzifus frzifus deleted the prepare-1.34.0 branch May 17, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenvp8510 rubenvp8510 rubenvp8510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default value for tls cipher-suites
2 participants
@frzifus @rubenvp8510