Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify stored search settings #111

Merged
merged 3 commits into from
Nov 6, 2017
Merged

Verify stored search settings #111

merged 3 commits into from
Nov 6, 2017

Commits on Oct 27, 2017

  1. Fix #92 browser prompt error 

    Services default to null when no traces have been encountered. Instead,
use an empty array.

Signed-off-by: Joe Farro <joef@uber.com>
    @tiffon
    tiffon committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    53e9a92 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue-92-browser-prompt-error' into issue-88-stored-sea… 

    …rch-settings
    @tiffon
    tiffon committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    eeb6465 View commit details
    Browse the repository at this point in the history

  3. Verify stored search values and preload operations 

    Fix #88.

Preload operations for stored service search value.

On the search page, show a loading indicator if the services are not yet loaded.
Then, only use the values stored in localStorage if they are consistent with
what has been loaded.

Signed-off-by: Joe Farro <joef@uber.com>
    @tiffon
    tiffon committed Oct 27, 2017
    Configuration menu
    Copy the full SHA
    21abefd View commit details
    Browse the repository at this point in the history