Render HTTP header tags as comma-separated strings #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrogers
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Signed-off-by: Will Rogers <wjrogers@gmail.com>
wjrogers
force-pushed
the
feature-otel-array-tags-#1294
branch
from
3f848da
to
466a41c
Compare
yurishkuro
reviewed
Mar 23, 2023
| expect(valueDiv.html()).toMatch(data[i].expected); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| it('renders HTTP headers as multiple string spans', () => { |
There was a problem hiding this comment.
This test feels very complicated & hard to maintain. Could we not use the .expected field above to define the exact output we want for the two new test cases?
There was a problem hiding this comment.
Sure. I was figuring out how the tests work and maybe got carried away. Will change it.
Signed-off-by: Will Rogers <wjrogers@gmail.com>
Signed-off-by: Will Rogers <wjrogers@gmail.com>
wjrogers
requested review from
yurishkuro
and removed request for
tiffon,
everett980 and
rubenvp8510
|
please run the linter, |
Signed-off-by: Will Rogers <wjrogers@gmail.com>
auto-merge was automatically disabled
March 23, 2023 19:14
Head branch was pushed to by a user without write access
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
+ Coverage 95.38% 95.54% +0.16%
==========================================
Files 244 244
Lines 7641 7651 +10
Branches 2003 2006 +3
==========================================
+ Hits 7288 7310 +22
+ Misses 353 341 -12
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Binrix
pushed a commit
to Binrix/jaeger-ui
that referenced
this pull request
Apr 18, 2023
## Which problem is this PR solving? Resolves jaegertracing#1294 ## Short description of the changes Change `formatValue` to check whether the (de-serialized) value is an array and, if so, whether the key should be rendered as a comma-separated list of strings. When both conditions are true, render the value like so: ```html <div class="json-markup"> <span class="json-markup-string">value1</span>, <span class="json-markup-string">value2</span> </div> ```  Currently, tag keys starting with `http.request.header.` and `http.response.header.` render as string lists. Please let me know if there are any other attributes I should include. --------- Signed-off-by: Will Rogers <wjrogers@gmail.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #1294
Short description of the changes
Change
formatValueto check whether the (de-serialized) value is an array and, if so, whether the key should be rendered as a comma-separated list of strings. When both conditions are true, render the value like so:Currently, tag keys starting with
http.request.header.andhttp.response.header.render as string lists. Please let me know if there are any other attributes I should include.