-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UNSAFE_componentWillMount lifecycle methods #611
Remove UNSAFE_componentWillMount lifecycle methods #611
Conversation
Codecov Report
@@ Coverage Diff @@
## master #611 +/- ##
==========================================
- Coverage 92.79% 92.77% -0.02%
==========================================
Files 227 227
Lines 5911 5911
Branches 1491 1491
==========================================
- Hits 5485 5484 -1
- Misses 385 386 +1
Partials 41 41
Continue to review full report at Codecov.
|
@rubenvp8510 mind taking a look? |
Refactor components to no longer use UNSAFE_componentWillMount methods adhering to current React best practices. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
d9c3e8a
to
386f47a
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Refactor components to no longer use UNSAFE_componentWillMount methods adhering to current React best practices. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Refactor components to no longer use UNSAFE_componentWillMount methods adhering to current React best practices. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Refactor components to no longer use UNSAFE_componentWillMount methods adhering to current React best practices. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Refactor components to no longer use UNSAFE_componentWillMount methods adhering to current React best practices.
Guides Used:
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#initializing-state
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#fetching-external-data
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#adding-event-listeners-or-subscriptions
Which problem is this PR solving?
Short description of the changes