Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disregard malformed references pointing to the same span #823

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

zimv
Copy link
Contributor

@zimv zimv commented Sep 30, 2021

Signed-off-by: zimv 472953586@qq.com

Which problem is this PR solving?

Short description of the changes

  • Add condition judgment in getFirstAncestor
function getFirstAncestor(span: Span): Span | TNil {
  return _get(
    _find(
      span.references,
      ({ span: ref, refType }) =>
        ref &&
        ref.spanID &&
        ref.spanID !== span.spanID &&
        (refType === 'CHILD_OF' || refType === 'FOLLOWS_FROM')
    ),
    'span'
  );
}

Signed-off-by: zimv <472953586@qq.com>
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
packages/jaeger-ui/src/utils/span-ancestor-ids.tsx 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@zimv zimv mentioned this pull request Jan 12, 2022
@yurishkuro yurishkuro changed the title Fix tracePage browser crash fix: Disregard malformed references pointing to the same span Oct 15, 2023
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Sorry, this PR fell through the cracks.

@yurishkuro yurishkuro merged commit 39459b0 into jaegertracing:main Oct 15, 2023
9 checks passed
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TracePage crash in browser
3 participants