-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tracing of Cassandra queries #1038
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1038 +/- ##
======================================
Coverage 100% 100%
======================================
Files 139 139
Lines 6419 6452 +33
======================================
+ Hits 6419 6452 +33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider spending a few more minutes thinking about the operation names, but having them follow the method then are in is also OK.
LGTM.
ad2344b
to
4ee81bb
Compare
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
4ee81bb
to
d2935ff
Compare
Signed-off-by: Yuri Shkuro <ys@uber.com>
Which problem is this PR solving?
Sometimes searching for spans takes a while, it is interesting to see where the time is spent, since the search in Cassandra is multi-step process.
Short description of the changes
Example: