Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archive traces to all-in-one #1189

Merged

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay ploffay@redhat.com

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #1189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1189   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         157     157           
  Lines        7107    7107           
======================================
  Hits         7107    7107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d32fc...dcf744c. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problems with the code, but why do we need this? In case all-in-one is used with persistent storage?

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Member Author

Yes, when it's used with real storage to provide the same functionality.

@pavolloffay pavolloffay merged commit c7da0b4 into jaegertracing:master Nov 16, 2018
@ghost ghost removed the review label Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants