Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaxConnectionAge[Grace] to collector's gRPC server #3422

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Add MaxConnectionAge[Grace] to collector's gRPC server #3422

merged 2 commits into from
Dec 2, 2021

Conversation

jpkrohling
Copy link
Contributor

Closes #1678 by adding two new flags, allowing operators to control the max-connection-age and max-connection-age-grace durations for the collector's gRPC server. Setting the max-connection-age to a few seconds/minutes will cause clients to rediscover collector nodes periodically, by forcing the subchannels to go away after it reaches a certain age. The grace option allows in-flight connections to complete before being forcefully closed.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling jpkrohling requested a review from a team as a code owner December 2, 2021 13:26
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #3422 (441faaf) into main (62cc3da) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
+ Coverage   96.48%   96.53%   +0.04%     
==========================================
  Files         261      261              
  Lines       15267    15277      +10     
==========================================
+ Hits        14731    14747      +16     
+ Misses        452      448       -4     
+ Partials       84       82       -2     
Impacted Files Coverage Δ
cmd/collector/app/builder_flags.go 100.00% <100.00%> (ø)
cmd/collector/app/collector.go 75.70% <100.00%> (+0.46%) ⬆️
cmd/collector/app/server/grpc.go 86.36% <100.00%> (+1.36%) ⬆️
plugin/storage/badger/spanstore/reader.go 96.21% <0.00%> (+0.70%) ⬆️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62cc3da...441faaf. Read the comment docs.

@jpkrohling jpkrohling enabled auto-merge (squash) December 2, 2021 14:02
@jpkrohling jpkrohling merged commit 0dd3e2d into jaegertracing:main Dec 2, 2021
@pavolloffay
Copy link
Member

This is great. Are there any recommended values for Kubernetes environment @jpkrohling ?

@jpkrohling
Copy link
Contributor Author

This is highly dependent on how elastic the deployment is: the more frequent the changes are, the lower the max-connection-age should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distirbution of traces/span amongst collector
3 participants