Convert token propagation integration test to plain unit test #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.11% // Head: 97.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4162 +/- ##
==========================================
+ Coverage 97.11% 97.12% +0.01%
==========================================
Files 296 296
Lines 17452 17452
==========================================
+ Hits 16948 16951 +3
+ Misses 406 403 -3
Partials 98 98
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Feb 22, 2023
…tracing#4162) ## Which problem is this PR solving? - `plugin/storage/integration/token_propagation_test.go` is using mock ES server created in the test itself - even though it also uses query service binary, it can be started directly in the unit test ## Short description of the changes - move the test to `cmd/query/app/token_propagation_test.go` as a unit test - simplify mock ES handler by relying on `bearertoken.PropagationHandler` - remove from scripts/es-integration-test.sh and simplify that script a bit Signed-off-by: Yuri Shkuro <github@ysh.us>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
…tracing#4162) ## Which problem is this PR solving? - `plugin/storage/integration/token_propagation_test.go` is using mock ES server created in the test itself - even though it also uses query service binary, it can be started directly in the unit test ## Short description of the changes - move the test to `cmd/query/app/token_propagation_test.go` as a unit test - simplify mock ES handler by relying on `bearertoken.PropagationHandler` - remove from scripts/es-integration-test.sh and simplify that script a bit Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
plugin/storage/integration/token_propagation_test.gois using mock ES server created in the test itselfShort description of the changes
cmd/query/app/token_propagation_test.goas a unit testbearertoken.PropagationHandler