New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Prometheus metrics as default mode #516

Merged
merged 3 commits into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@yurishkuro
Member

yurishkuro commented Nov 7, 2017

Depends in jaegertracing/jaeger-lib#29

Resolves #360, partially #273 .

@wafflebot wafflebot bot added the review label Nov 7, 2017

@yurishkuro yurishkuro changed the title from [WIP] Support Prometheus metrics in the agent to [WIP] Support Prometheus metrics Nov 12, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 12, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling 7fbd871 on prometheus-metrics into 32e2cd3 on master.

coveralls commented Nov 12, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling 7fbd871 on prometheus-metrics into 32e2cd3 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 12, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling 7fbd871 on prometheus-metrics into 32e2cd3 on master.

coveralls commented Nov 12, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling 7fbd871 on prometheus-metrics into 32e2cd3 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 13, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling eb29339 on prometheus-metrics into 32e2cd3 on master.

coveralls commented Nov 13, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling eb29339 on prometheus-metrics into 32e2cd3 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 13, 2017

Coverage Status

Coverage increased (+0.02%) to 99.969% when pulling 05603c0 on prometheus-metrics into 32e2cd3 on master.

coveralls commented Nov 13, 2017

Coverage Status

Coverage increased (+0.02%) to 99.969% when pulling 05603c0 on prometheus-metrics into 32e2cd3 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 13, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling 535fabf on prometheus-metrics into 32e2cd3 on master.

coveralls commented Nov 13, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling 535fabf on prometheus-metrics into 32e2cd3 on master.

@@ -116,7 +116,7 @@ func (spanHb *SpanHandlerBuilder) initElasticStore(esBuilder escfg.ClientBuilder
// BuildHandlers builds span handlers (Zipkin, Jaeger)
func (spanHb *SpanHandlerBuilder) BuildHandlers() (app.ZipkinSpansHandler, app.JaegerBatchesHandler) {
hostname, _ := os.Hostname()
hostMetrics := spanHb.metricsFactory.Namespace(hostname, nil)
hostMetrics := spanHb.metricsFactory.Namespace("", map[string]string{"host": hostname})

This comment has been minimized.

@yurishkuro

yurishkuro Nov 13, 2017

Member

NOTE: this is a breaking change, but without it the crossdock test was failing with "49d962b96482:save_latency" is not a valid metric name because the host name was used as a prefix.

@yurishkuro

yurishkuro Nov 13, 2017

Member

NOTE: this is a breaking change, but without it the crossdock test was failing with "49d962b96482:save_latency" is not a valid metric name because the host name was used as a prefix.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 13, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling 23420ab on prometheus-metrics into 32e2cd3 on master.

coveralls commented Nov 13, 2017

Coverage Status

Coverage increased (+0.05%) to 100.0% when pulling 23420ab on prometheus-metrics into 32e2cd3 on master.

@yurishkuro yurishkuro changed the title from [WIP] Support Prometheus metrics to Support Prometheus metrics as default mode Nov 13, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 3afc106 on prometheus-metrics into 5db9cde on master.

coveralls commented Nov 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 3afc106 on prometheus-metrics into 5db9cde on master.

yurishkuro added some commits Nov 27, 2017

Enable Prometheus metrics as default for all components
Signed-off-by: Yuri Shkuro <ys@uber.com>
Fix demo init
Signed-off-by: Yuri Shkuro <ys@uber.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 9707610 on prometheus-metrics into ecb6609 on master.

coveralls commented Nov 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 9707610 on prometheus-metrics into ecb6609 on master.

Show outdated Hide outdated pkg/metrics/builder.go Outdated
Fix imports
Signed-off-by: Yuri Shkuro <ys@uber.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b263332 on prometheus-metrics into ecb6609 on master.

coveralls commented Nov 27, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b263332 on prometheus-metrics into ecb6609 on master.

@yurishkuro yurishkuro merged commit 9988a3d into master Nov 28, 2017

4 of 5 checks passed

License Compliance 3 issues found.
Details
DCO All commits have a DCO sign-off from the author
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@wafflebot wafflebot bot removed the review label Nov 28, 2017

@yurishkuro yurishkuro deleted the prometheus-metrics branch Dec 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment