Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Extend integration tests for memstore #5215

Conversation

akagami-harsh
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Extended integration tests for memstore used in jaeger-v2

How was this change tested?

  • tested locally

Checklist

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5375e1e) 94.44% compared to head (e61caa3) 94.48%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5215      +/-   ##
==========================================
+ Coverage   94.44%   94.48%   +0.03%     
==========================================
  Files         332      334       +2     
  Lines       19189    19254      +65     
==========================================
+ Hits        18124    18192      +68     
+ Misses        878      875       -3     
  Partials      187      187              
Flag Coverage Δ
cassandra-3.x 28.65% <ø> (+3.07%) ⬆️
cassandra-4.x 28.65% <ø> (+3.07%) ⬆️
elasticsearch-5.x 23.70% <ø> (+3.84%) ⬆️
elasticsearch-6.x 23.70% <ø> (+3.84%) ⬆️
elasticsearch-7.x 23.84% <ø> (+3.84%) ⬆️
elasticsearch-8.x 23.93% <ø> (+3.84%) ⬆️
grpc-badger 20.12% <ø> (+0.63%) ⬆️
kafka 19.63% <ø> (+5.54%) ⬆️
opensearch-1.x 23.84% <ø> (+3.84%) ⬆️
opensearch-2.x 23.84% <ø> (+3.85%) ⬆️
unittests 92.30% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

Sorry, I don't follow what problem this PR is solving. memstore is already tested in in integration tests.

@akagami-harsh akagami-harsh deleted the memstoreIntegraionTests branch February 21, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants