Replaced the deprecated logging exporter to debug exporter #5291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcell Majer <majer.marcell@telekom.hu>
majermarci
force-pushed
the
replacedLoggingWithDebugExp
branch
from
4381dbe
to
d3385fe
Compare
frzifus
approved these changes
Mar 22, 2024
pavolloffay
added
the
changelog:skip
pavolloffay
approved these changes
Mar 22, 2024
pavolloffay
reviewed
Mar 22, 2024
| @@ -13,7 +13,7 @@ import ( | |||
| "go.opentelemetry.io/collector/connector" | |||
| "go.opentelemetry.io/collector/connector/forwardconnector" | |||
| "go.opentelemetry.io/collector/exporter" | |||
| "go.opentelemetry.io/collector/exporter/loggingexporter" | |||
There was a problem hiding this comment.
It is a breaking change but acceptable as the v2 hasn't been released.
Signed-off-by: Marcell Majer <majer.marcell@telekom.hu>
majermarci
force-pushed
the
replacedLoggingWithDebugExp
branch
from
3f8b999
to
4b7c9b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5291 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 340 340
Lines 16610 16610
=======================================
Hits 15791 15791
Misses 630 630
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
added 2 commits
March 22, 2024 15:13
Signed-off-by: Marcell Majer <majer.marcell@telekom.hu>
Signed-off-by: Marcell Majer <majer.marcell@telekom.hu>
pavolloffay
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it's my first very basic PR.
I removed
loggingexportersince it's deprecated and replaced it with thedebugexporter.