Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test goroutine leaks in ./cmd/collector/app/ #5292

Conversation

WillSewell
Copy link
Contributor

@WillSewell WillSewell commented Mar 22, 2024

Which problem is this PR solving?

Solves part of #5006.

Description of the changes

I introduced testutils.VerifyGoLeaks(m) and then ensured all leaked goroutines were stopped.

How was this change tested?

make lint and make test

Checklist

@WillSewell WillSewell requested a review from a team as a code owner March 22, 2024 14:00
@WillSewell WillSewell marked this pull request as draft March 22, 2024 14:00
@yurishkuro
Copy link
Member

Please make sure all commits are signed. See CONTRIBUTING.md

@WillSewell WillSewell force-pushed the fix-goroutine-leaks-cmd-collector-app branch from 0a3c98c to cd9261b Compare March 22, 2024 14:14
Solves part of jaegertracing#5006.

Signed-off-by: Will Sewell <willsewell@monzo.com>
@WillSewell WillSewell force-pushed the fix-goroutine-leaks-cmd-collector-app branch from cd9261b to 2b0c4dd Compare March 22, 2024 14:17
@WillSewell WillSewell marked this pull request as ready for review March 22, 2024 14:18
@WillSewell
Copy link
Contributor Author

Sorry, just force-pushed a signed commit.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (db8c04c) to head (2b0c4dd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5292      +/-   ##
==========================================
+ Coverage   95.06%   95.08%   +0.01%     
==========================================
  Files         340      340              
  Lines       16610    16615       +5     
==========================================
+ Hits        15791    15798       +7     
+ Misses        630      629       -1     
+ Partials      189      188       -1     
Flag Coverage Δ
badger 13.26% <ø> (ø)
cassandra-3.x 26.44% <ø> (ø)
cassandra-4.x 26.44% <ø> (ø)
elasticsearch-5.x 21.70% <ø> (ø)
elasticsearch-6.x 21.70% <ø> (+0.01%) ⬆️
elasticsearch-7.x 21.77% <ø> (ø)
elasticsearch-8.x 21.87% <ø> (ø)
grpc 10.89% <ø> (-0.02%) ⬇️
kafka 14.73% <ø> (ø)
opensearch-1.x 21.77% <ø> (-0.02%) ⬇️
opensearch-2.x 21.78% <ø> (+0.01%) ⬆️
unittests 92.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillSewell
Copy link
Contributor Author

Thanks for the approval @pavolloffay (also thanks for hosting the kubecon contribfest - I was there!)

Could you add the label that is causing CI to fail please? I don't think I have permission.

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Mar 23, 2024
@yurishkuro yurishkuro merged commit d887b74 into jaegertracing:main Mar 23, 2024
36 of 38 checks passed
@yurishkuro
Copy link
Member

Thanks!

@WillSewell WillSewell deleted the fix-goroutine-leaks-cmd-collector-app branch March 23, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants