-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use math.MaxUint64 instead of 0xffffffffffffffff #5294
Conversation
Signed-off-by: majorteach <csgcgl@126.com>
Hmm.. is there any explanation why is this PR needed? Maybe adding the "Which problem is this PR solving?" will clarify things, because I can't see what is this PR trying to solve. 🤔 |
Thanks. Modified |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5294 +/- ##
=======================================
Coverage 95.08% 95.08%
=======================================
Files 340 340
Lines 16626 16626
=======================================
Hits 15809 15809
- Misses 628 629 +1
+ Partials 189 188 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@majorteach there is a Github CI check failing, it is because your PR is opened from the main branch of your fork. As we're not allowed to directly push commits to |
Thanks! |
The new PR #5295 I checkout from main and use another branch name. Thanks |
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> Use the variables included in the go standard library to make the code clearer The same as #5294 ## Description of the changes - Math MaxUint64 is a constant currently defined in the go standard library and can be used directly without having to define it repeatedly ## How was this change tested? - no need ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: majorteach <csgcgl@126.com>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test