Use healthcheck to mark cassandra-schema container as ready #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
requested review from
black-adder,
pavolloffay and
vprithvi
as code owners
ghost
assigned Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
force-pushed
the
add-schema-check
branch
from
aa43d09
to
811e524
Compare
Signed-off-by: Yuri Shkuro <ys@uber.com>
Closed
pavolloffay
reviewed
Nov 19, 2017
| - AXIS_SERVICES=go,node,java,python,zipkin-brave-json,zipkin-brave-json-v2,zipkin-brave-thrift | ||
|
|
||
| - BEHAVIOR_ENDTOEND=client,services | ||
| depends_on: |
There was a problem hiding this comment.
this is not necessary because there is already a link.
| @@ -1,4 +1,4 @@ | |||
| version: '2' | |||
| version: '3' | |||
There was a problem hiding this comment.
this can break xdocks in other clients. But am +1 on version 3.
There was a problem hiding this comment.
yeah, I am aware that it will break other clients. We don't need to bump it if we don't have a use for the healthcheck, which was added in 2.1
There was a problem hiding this comment.
with version 3 we could perhaps also use configs (something like configmap in k8s) to split templates for ES and C*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #547