Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove numBuckets argument from CreateSamplingStore() API #5635

Closed

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 16, 2024

Which problem is this PR solving?

  • CreateSamplingStore() used to require numBuckets argument. However, only memory storage was dependent on this arg. This creates an unnecessary coupling in adaptive sampling between aggregator and provider.

Description of the changes

How was this change tested?

  • CI

@yurishkuro yurishkuro changed the title [WIP] Sampling store no buckets [WIP] Remove numBuckets argument from CreateSamplingStore() API Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (d8185ac) to head (b6c45b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5635      +/-   ##
==========================================
+ Coverage   96.20%   96.22%   +0.02%     
==========================================
  Files         327      326       -1     
  Lines       16014    16009       -5     
==========================================
- Hits        15406    15405       -1     
+ Misses        432      427       -5     
- Partials      176      177       +1     
Flag Coverage Δ
badger_v1 8.05% <6.25%> (-0.01%) ⬇️
badger_v2 1.93% <0.00%> (-0.01%) ⬇️
cassandra-3.x-v1 16.44% <6.25%> (-0.01%) ⬇️
cassandra-3.x-v2 1.85% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 16.44% <6.25%> (-0.01%) ⬇️
cassandra-4.x-v2 1.85% <0.00%> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.89% <6.25%> (-0.01%) ⬇️
elasticsearch-8.x-v1 19.07% <6.25%> (-0.01%) ⬇️
elasticsearch-8.x-v2 19.07% <6.25%> (-0.02%) ⬇️
grpc_v1 9.50% <56.25%> (+0.02%) ⬆️
grpc_v2 7.57% <50.00%> (+0.03%) ⬆️
kafka 9.77% <25.00%> (-0.01%) ⬇️
opensearch-1.x-v1 18.92% <6.25%> (-0.01%) ⬇️
opensearch-2.x-v1 18.93% <6.25%> (+<0.01%) ⬆️
opensearch-2.x-v2 18.92% <6.25%> (-0.02%) ⬇️
unittests 94.10% <94.73%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro force-pushed the sampling-store-no-buckets branch 3 times, most recently from 006628a to 94af1ed Compare June 16, 2024 17:05
Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant