-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target docker-images-jaeger-backend in Makefile #5658
Conversation
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5658 +/- ##
==========================================
- Coverage 96.37% 96.36% -0.02%
==========================================
Files 327 327
Lines 16028 16028
==========================================
- Hits 15447 15445 -2
- Misses 404 405 +1
- Partials 177 178 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Makefile.Integration.mk
Outdated
docker buildx build --target $(TARGET) \ | ||
--tag $(DOCKER_NAMESPACE)/$$component$(SUFFIX):${DOCKER_TAG} \ | ||
--build-arg base_image=$(BASE_IMAGE) \ | ||
--build-arg debug_image=$(DEBUG_IMAGE) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I use the BASE_IMAGE here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could try. I see that the way Dockerfile is designed you cannot skip building debug image. But the main time is actually spent on building the base debug image (where we need to download and build delve), so maybe it's ok.
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Superseded by #5663 |
Which problem is this PR solving?
Description of the changes
docker-images-jaeger-backend
inMakefile.Integration.mk
How was this change tested?
make build
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test