Increase domain for model.TimeAsEpochMicroseconds #730
Conversation
vprithvi
requested review from
black-adder,
pavolloffay and
yurishkuro
as code owners
ghost
assigned
vprithvi
force-pushed
the
support-large-time
branch
from
589e8f3
to
4bd8e2d
Compare
|
On another note, what do you think about also adding warnings when converting representation formats (model to thrift/ thrift to model, etc) when current time and span time differ by more than a week? |
Use `time.Unix()` instead of `time.UnixNano()` when the input exceeds the domain of `time.UnixNano()` Signed-off-by: Prithvi Raj <p.r@uber.com>
vprithvi
force-pushed
the
support-large-time
branch
from
4bd8e2d
to
d26d691
Compare
There was a problem hiding this comment.
+1 to Won's comment - not good to silently change the data. The cause of the issue seems to be bad instrumentation clients that are sending invalid micros, so best way would be to handle this on ingestion and try to recover (the value is most likely 1000x than needed), as well as capture a warning in the span.
| // represented by an int64(less than year 1678 or greater than year 2262) | ||
| return uint64(t.UnixNano() / 1000) | ||
| } | ||
| return uint64(t.Unix() * 1e6) |
There was a problem hiding this comment.
not sure I follow - doesn't this just truncate to full seconds? Isn't there a way to retrieve the sub-second digits, maybe without using UnixNanos()?
| @@ -26,7 +26,12 @@ func EpochMicrosecondsAsTime(ts uint64) time.Time { | |||
| // TimeAsEpochMicroseconds converts time.Time to microseconds since epoch, | |||
| // which is the format the StartTime field is stored in the Span. | |||
| func TimeAsEpochMicroseconds(t time.Time) uint64 { | |||
| return uint64(t.UnixNano() / 1000) | |||
| if t.Year() > 1678 && t.Year() < 2262 { | |||
There was a problem hiding this comment.
if y := t.Year(); y > 1678 && y < 2262 {}
|
@vprithvi could you please push the branch to your fork and remove this branch? |
Use
time.Unix()instead oftime.UnixNano()when the input exceeds the domain oftime.UnixNano()Signed-off-by: Prithvi Raj p.r@uber.com