Fail test if the expected and actual traces differ (#777) #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
requested review from
black-adder,
pavolloffay,
vprithvi and
yurishkuro
as code owners
ghost
assigned 
yurishkuro
previously approved these changes
Apr 23, 2018
yurishkuro
reviewed
Apr 23, 2018
| } | ||
|
|
||
| diff := pretty.Diff(expected, actual) | ||
| if len(diff) > 0 { |
There was a problem hiding this comment.
nit: combine into one line: if diff := pretty.Diff(expected, actual); len(diff) > 0 {
yurishkuro
reviewed
Apr 23, 2018
|
|
||
| diff := pretty.Diff(expected, actual) | ||
| if len(diff) > 0 { | ||
| t.Logf("Expected and actual differ: %v\n", diff) |
There was a problem hiding this comment.
when there are many differences, this doesn't print them in easily readable way. I prefer the loop as before.
burmanm
force-pushed
the
fix_storage_integration_test
branch
from
6cac6a7
to
008eec8
Compare
Use pretty.Diff(expected, actual) instead of reflect.DeepEqual(expected, actual) to check for equality between given and received trace. Also, if there is a difference, set the test to fail instead of only logging the failed trace. Signed-off-by: Michael Burman <miburman@redhat.com>
burmanm
force-pushed
the
fix_storage_integration_test
branch
from
008eec8
to
455a85d
Compare
|
Yep, modified based on the review. |
|
looks like the builds are failing due to #786 |
yurishkuro
approved these changes
Apr 24, 2018
yurishkuro
reviewed
Apr 24, 2018
|
|
||
| if diff := pretty.Diff(expected, actual); len(diff) > 0 { | ||
| for _, d := range diff { | ||
| t.Logf("Expected and actual differ: %v\n", d) |
There was a problem hiding this comment.
nit: \n is not necessary, but ok
|
thanks @burmanm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pretty.Diff(expected, actual) instead of reflect.DeepEqual(expected, actual) to check for equality between given and received trace. Also, if there is a difference, set the test to fail instead of only logging the failed trace.
And prettify the storage-integration-test output