Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use KeyValue fields directly and use KeyValues as decorator only #810

Merged
merged 2 commits into from May 7, 2018

Conversation

Projects
None yet
3 participants
@yurishkuro
Copy link
Member

commented May 7, 2018

Addresses first two issues in #773 (comment)

  • Do not use KeyValue fields like VNum directly
  • Use KeyValues as decorator only

yurishkuro added some commits May 7, 2018

Do not use KeyValue fields directly
Signed-off-by: Yuri Shkuro <ys@uber.com>
Use KeyValues as decorator only
Signed-off-by: Yuri Shkuro <ys@uber.com>

@ghost ghost assigned yurishkuro May 7, 2018

@ghost ghost added the review label May 7, 2018

@coveralls

This comment has been minimized.

Copy link

commented May 7, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling f1604a6 on do-not-use-keyvalue-fields-directly into 4106c29 on master.

@yurishkuro yurishkuro merged commit 5eb2922 into master May 7, 2018

5 of 6 checks passed

License Compliance 2 issues found.
Details
DCO All commits have a DCO sign-off from the author
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@ghost ghost removed the review label May 7, 2018

mabn added a commit to mabn/jaeger that referenced this pull request May 28, 2018

Merge branch 'master' into influx
* master: (38 commits)
  Preparing release 1.5.0 (jaegertracing#847)
  Add bounds to memory storage (jaegertracing#845)
  Add metric for debug traces (jaegertracing#796)
  Change metrics naming scheme (jaegertracing#776)
  Bump gocql version (jaegertracing#829)
  Remove ParentSpanID from domain model (jaegertracing#831)
  Make gas run quiet (jaegertracing#838)
  Revert "Make gas run quite"
  Revert "Install gas from install-ci"
  Install gas from install-ci
  Make gas run quite
  Add 'gas' for security problems scanning (jaegertracing#830)
  Add ability to adjust static sampling probabilities per operation (jaegertracing#827)
  Support log-level flag on agent (jaegertracing#828)
  Remove unused function (jaegertracing#822)
  Add healthcheck to standalone (jaegertracing#784)
  Do not use KeyValue fields directly and use KeyValues as decorator only (jaegertracing#810)
  Add ContaAzul to the adopters list (jaegertracing#806)
  Add ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE (jaegertracing#805)
  Upgrade to  go 1.10 (jaegertracing#792)
  ...

# Conflicts:
#	cmd/agent/app/builder.go
#	cmd/collector/main.go
#	cmd/query/main.go
#	cmd/standalone/main.go

@pavolloffay pavolloffay deleted the do-not-use-keyvalue-fields-directly branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.