Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support log-level flag on agent #828

Merged
merged 1 commit into from
May 17, 2018
Merged

Support log-level flag on agent #828

merged 1 commit into from
May 17, 2018

Conversation

black-adder
Copy link
Contributor

@black-adder black-adder commented May 17, 2018

Signed-off-by: Won Jun Jang wjang@uber.com

Which problem is this PR solving?

Short description of the changes

  • Expose the --log-level flag but only the --log-level flag and not the rest of the shared flags

Signed-off-by: Won Jun Jang <wjang@uber.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8e0a027 on fix_agent_log_flag into b5ade19 on master.

@@ -73,6 +73,7 @@ func main() {
v,
command,
flags.AddConfigFileFlag,
flags.AddLoggingFlag,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're certainly adding it to the cmd line, but is it being used by main to control logging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, on L45

@yurishkuro
Copy link
Member

tip: say resolves #803, not with a link

@black-adder black-adder merged commit cf242c3 into master May 17, 2018
@black-adder black-adder deleted the fix_agent_log_flag branch May 17, 2018 14:21
mabn pushed a commit to mabn/jaeger that referenced this pull request May 28, 2018
* master: (38 commits)
  Preparing release 1.5.0 (jaegertracing#847)
  Add bounds to memory storage (jaegertracing#845)
  Add metric for debug traces (jaegertracing#796)
  Change metrics naming scheme (jaegertracing#776)
  Bump gocql version (jaegertracing#829)
  Remove ParentSpanID from domain model (jaegertracing#831)
  Make gas run quiet (jaegertracing#838)
  Revert "Make gas run quite"
  Revert "Install gas from install-ci"
  Install gas from install-ci
  Make gas run quite
  Add 'gas' for security problems scanning (jaegertracing#830)
  Add ability to adjust static sampling probabilities per operation (jaegertracing#827)
  Support log-level flag on agent (jaegertracing#828)
  Remove unused function (jaegertracing#822)
  Add healthcheck to standalone (jaegertracing#784)
  Do not use KeyValue fields directly and use KeyValues as decorator only (jaegertracing#810)
  Add ContaAzul to the adopters list (jaegertracing#806)
  Add ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE (jaegertracing#805)
  Upgrade to  go 1.10 (jaegertracing#792)
  ...

# Conflicts:
#	cmd/agent/app/builder.go
#	cmd/collector/main.go
#	cmd/query/main.go
#	cmd/standalone/main.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jaeger-agent: --log-level flag not recognized
3 participants