Remove ParentSpanID from domain model #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
requested review from
black-adder,
pavolloffay and
vprithvi
as code owners
ghost
assigned 
black-adder
approved these changes
May 18, 2018
| func (s *Span) ParentSpanID() SpanID { | ||
| for i := range s.References { | ||
| ref := &s.References[i] | ||
| if ref.TraceID == s.TraceID && ref.RefType == ChildOf { |
There was a problem hiding this comment.
i've always wondered, why do we need traceid to be part of spanref? what use case is there when a span has a spanref to a different traceid?
There was a problem hiding this comment.
meta-traces; multi-trace joins in buffered writes
| // ParentSpanID returns ID of a parent span if it exists. | ||
| // It searches for the first child-of reference pointing to the same trace ID. | ||
| func (s *Span) ParentSpanID() SpanID { | ||
| for i := range s.References { |
There was a problem hiding this comment.
why not iterate over the reference directly? ie for _, ref :=
There was a problem hiding this comment.
each iteration will have to copy 4 words into the on-stack var
yurishkuro
force-pushed
the
remove-parent-span-id
branch
3 times, most recently
from
8b08701
to
beb4a57
Compare
added 2 commits
May 18, 2018 16:27
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
force-pushed
the
remove-parent-span-id
branch
from
beb4a57
to
3ed6401
Compare
mabn
pushed a commit
to mabn/jaeger
that referenced
this pull request
May 28, 2018
* master: (38 commits) Preparing release 1.5.0 (jaegertracing#847) Add bounds to memory storage (jaegertracing#845) Add metric for debug traces (jaegertracing#796) Change metrics naming scheme (jaegertracing#776) Bump gocql version (jaegertracing#829) Remove ParentSpanID from domain model (jaegertracing#831) Make gas run quiet (jaegertracing#838) Revert "Make gas run quite" Revert "Install gas from install-ci" Install gas from install-ci Make gas run quite Add 'gas' for security problems scanning (jaegertracing#830) Add ability to adjust static sampling probabilities per operation (jaegertracing#827) Support log-level flag on agent (jaegertracing#828) Remove unused function (jaegertracing#822) Add healthcheck to standalone (jaegertracing#784) Do not use KeyValue fields directly and use KeyValues as decorator only (jaegertracing#810) Add ContaAzul to the adopters list (jaegertracing#806) Add ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE (jaegertracing#805) Upgrade to go 1.10 (jaegertracing#792) ... # Conflicts: # cmd/agent/app/builder.go # cmd/collector/main.go # cmd/query/main.go # cmd/standalone/main.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #824
This implements option 1 from #824 by removing ParentSpanID from the domain model and only using the References array.
ParentSpanIDis replaced with an accessorParentSpanID()that returns the span ID of the firstchild-ofreference for the same trace ID.Once unfortunate discovery: both Cassandra and Elasticsearch models kept the ParentID field in their respective models. It is no longer populated in the domain->db model conversions, but still has to be taken into account in the dbmodel->domain conversion for backwards compatibility with existing data. I don't know of a better solution.
A side effect of that is that we won't be able to use gogoprotobuf-generated model (from #773) to generate the JSON for Elasticsearch. The plan would be to move
model/converter/jsoncode intoplugin/storage/es/dbmodel, similar toplugin/storage/cassandra/dbmodel, while the UI JSON model will be produced directly from protobuf model.This change is