Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release 1.5.0 #847

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
3 participants
@jpkrohling
Copy link
Member

commented May 28, 2018

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

  • Release 1.5.0

Short description of the changes

  • User-visible changes from 1.4.1 to 1.5.0 added to the changelog

@ghost ghost assigned jpkrohling May 28, 2018

@ghost ghost added the review label May 28, 2018

@coveralls

This comment has been minimized.

Copy link

commented May 28, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 62f53e7 on jpkrohling:Release-1.5.0 into 7796f75 on jaegertracing:master.

@pavolloffay
Copy link
Member

left a comment

LGTM, just one missing link.

Could we start using *this changelog format for an entry? I have started it using in https://github.com/jaegertracing/jaeger-client-java/pull/429/files. K8s using it, the benefit is that links work in readmes (in release page too).

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.9.md#other-notable-changes-1

- Description ([ref](), [who]())

- Add ability to adjust static sampling probabilities per operation (#827) by Won Jun Jang (@black-adder)
- Support log-level flag on agent (#828) by Won Jun Jang (@black-adder)
- Add healthcheck to standalone (#784) by Eundoo Song (@eundoosong)
- Do not use KeyValue fields directly and use KeyValues as decorator only by Yuri Shkuro (@yurishkuro)

This comment has been minimized.

Copy link
@pavolloffay

pavolloffay May 28, 2018

Member

missing PR reference

This comment has been minimized.

Copy link
@jpkrohling

jpkrohling May 28, 2018

Author Member

Updated

@pavolloffay

This comment has been minimized.

Copy link
Member

commented May 28, 2018

I have created #848 to create guidelines

Preparing release 1.5.0
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

@jpkrohling jpkrohling force-pushed the jpkrohling:Release-1.5.0 branch from 3782498 to 62f53e7 May 28, 2018

@jpkrohling

This comment has been minimized.

Copy link
Member Author

commented May 28, 2018

PR updated to fix the reference to 810 in one of the commits

@pavolloffay

This comment has been minimized.

Copy link
Member

commented May 28, 2018

I guess you don't want to update the links to fit with #848 so I will merge

@pavolloffay pavolloffay merged commit ab77ac7 into jaegertracing:master May 28, 2018

4 checks passed

DCO All commits have a DCO sign-off from the author
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@ghost ghost removed the review label May 28, 2018

@jpkrohling

This comment has been minimized.

Copy link
Member Author

commented May 28, 2018

I would have no problems doing that, but I think this is a discussion we can have for the next release :)

mabn added a commit to mabn/jaeger that referenced this pull request May 28, 2018

Merge branch 'master' into influx
* master: (38 commits)
  Preparing release 1.5.0 (jaegertracing#847)
  Add bounds to memory storage (jaegertracing#845)
  Add metric for debug traces (jaegertracing#796)
  Change metrics naming scheme (jaegertracing#776)
  Bump gocql version (jaegertracing#829)
  Remove ParentSpanID from domain model (jaegertracing#831)
  Make gas run quiet (jaegertracing#838)
  Revert "Make gas run quite"
  Revert "Install gas from install-ci"
  Install gas from install-ci
  Make gas run quite
  Add 'gas' for security problems scanning (jaegertracing#830)
  Add ability to adjust static sampling probabilities per operation (jaegertracing#827)
  Support log-level flag on agent (jaegertracing#828)
  Remove unused function (jaegertracing#822)
  Add healthcheck to standalone (jaegertracing#784)
  Do not use KeyValue fields directly and use KeyValues as decorator only (jaegertracing#810)
  Add ContaAzul to the adopters list (jaegertracing#806)
  Add ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE (jaegertracing#805)
  Upgrade to  go 1.10 (jaegertracing#792)
  ...

# Conflicts:
#	cmd/agent/app/builder.go
#	cmd/collector/main.go
#	cmd/query/main.go
#	cmd/standalone/main.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.