Preparing release 1.5.0 #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
requested review from
black-adder,
pavolloffay,
vprithvi and
yurishkuro
as code owners
ghost
assigned 
pavolloffay
approved these changes
May 28, 2018
There was a problem hiding this comment.
LGTM, just one missing link.
Could we start using *this changelog format for an entry? I have started it using in https://github.com/jaegertracing/jaeger-client-java/pull/429/files. K8s using it, the benefit is that links work in readmes (in release page too).
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.9.md#other-notable-changes-1
- Description ([ref](), [who]())
CHANGELOG.md
Outdated
| - Add ability to adjust static sampling probabilities per operation (#827) by Won Jun Jang (@black-adder) | ||
| - Support log-level flag on agent (#828) by Won Jun Jang (@black-adder) | ||
| - Add healthcheck to standalone (#784) by Eundoo Song (@eundoosong) | ||
| - Do not use KeyValue fields directly and use KeyValues as decorator only by Yuri Shkuro (@yurishkuro) |
|
I have created #848 to create guidelines |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
|
PR updated to fix the reference to 810 in one of the commits |
|
I guess you don't want to update the links to fit with #848 so I will merge |
|
I would have no problems doing that, but I think this is a discussion we can have for the next release :) |
mabn
pushed a commit
to mabn/jaeger
that referenced
this pull request
May 28, 2018
* master: (38 commits) Preparing release 1.5.0 (jaegertracing#847) Add bounds to memory storage (jaegertracing#845) Add metric for debug traces (jaegertracing#796) Change metrics naming scheme (jaegertracing#776) Bump gocql version (jaegertracing#829) Remove ParentSpanID from domain model (jaegertracing#831) Make gas run quiet (jaegertracing#838) Revert "Make gas run quite" Revert "Install gas from install-ci" Install gas from install-ci Make gas run quite Add 'gas' for security problems scanning (jaegertracing#830) Add ability to adjust static sampling probabilities per operation (jaegertracing#827) Support log-level flag on agent (jaegertracing#828) Remove unused function (jaegertracing#822) Add healthcheck to standalone (jaegertracing#784) Do not use KeyValue fields directly and use KeyValues as decorator only (jaegertracing#810) Add ContaAzul to the adopters list (jaegertracing#806) Add ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE (jaegertracing#805) Upgrade to go 1.10 (jaegertracing#792) ... # Conflicts: # cmd/agent/app/builder.go # cmd/collector/main.go # cmd/query/main.go # cmd/standalone/main.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de
Which problem is this PR solving?
Short description of the changes