Intelligent errors.Cause() #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puellanivis
suggested changes
Dec 21, 2017
errors.go
Outdated
| } | ||
| err = cause.Cause() |
There was a problem hiding this comment.
If you never update err, then this for loop can never finish, and it is now possible that the loop becomes a forever loop.
There was a problem hiding this comment.
heh, was just about to test. thank you.
When causer.Cause() returns nil or itself, it is the cause.
jaekwon
force-pushed
the
intelligent-cause
branch
from
c1d72bb
to
42f0164
Compare
|
Closing this to open a PR on pkg/errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When causer.Cause() returns nil or itself, it is the cause.
Ref: pkg#89