Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve end of headers detection #3

Closed
jaemk opened this issue Nov 17, 2017 · 0 comments
Closed

Improve end of headers detection #3

jaemk opened this issue Nov 17, 2017 · 0 comments

Comments

@jaemk
Copy link
Owner

jaemk commented Nov 17, 2017

End of header detection could be improved avoid scanning through the entire buffer each try_build_request and to put off header counting until all of them are received. This probably overlaps with #2 since it'll require tracking the current number of bytes
jaemk added a commit that referenced this issue Nov 19, 2017
@jaemk
request header parsing
a131371 
issue #3
- cleanup end of headers detection
- scan incrementally with a cursor instead of looking
  through the whole thing every time
- fix body_bytes_read calculation
    - body_bytes_read tracks the number of body bytes that were
      read that came in the with final chunk of header data
    - an extra calculation was zeroing out this value. If all data
      came in a single read-chunk, then content-length was effectively
      ignored
@jaemk jaemk closed this as completed Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaemk