Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashsms argument not working #14

Closed
steneram opened this issue Oct 19, 2016 · 3 comments
Closed

Flashsms argument not working #14

steneram opened this issue Oct 19, 2016 · 3 comments
Labels

Comments

@steneram
Copy link

I upgraded to latest version of this gem and when using
Elk::SMS.send(from: "Test", flashsms: "yes", to: user.phone, message: "Meddelande")
I don't seem to get a flashsms anymore, i get a normal text sent to the phone instead. I do not get any errors it just seems to ignore the flashsms parameter.

@steneram
Copy link
Author

So the parameter is no longer flashsms: "yes" it is instead flash: "yes"

@jage
Copy link
Owner

jage commented Oct 19, 2016

Oh, I think the intent was to keep the old keyword to avoid breaking compatibility.

@flexiqube which version did you use before, and which version are you using now?

@jage jage reopened this Oct 19, 2016
@jage jage added the bug label Oct 19, 2016
@steneram
Copy link
Author

steneram commented Oct 19, 2016

I used the older one, before you dropped support for Ruby 1.8. When i looked at the documentation in your code i saw that you used flash: instead of flashsms: so i tried that and it worked fine with the new version.

@jage jage closed this as completed in 5ac0e70 Nov 12, 2017
jage added a commit that referenced this issue Nov 12, 2017
Release fix for #14
@jage jage changed the title Flashsms not working anymore? Flashsms argument not working Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants