Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bumped Webmock, split up the specs so they're easier to read and added better support for flashsms. I think it's better to coerce the flash value, which preferably is a boolean, in the library itself instead of the user needing to do it.
Of course,
:flashsms => 'yes'
, still works.Maybe if the coercion and checking of parameters continue to grow, it should be extracted out of the
send
method. What do you think?