Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for better flashsms. #8

Merged
merged 7 commits into from
May 1, 2013
Merged

Support for better flashsms. #8

merged 7 commits into from
May 1, 2013

Conversation

mattiassvedhem
Copy link
Contributor

I bumped Webmock, split up the specs so they're easier to read and added better support for flashsms. I think it's better to coerce the flash value, which preferably is a boolean, in the library itself instead of the user needing to do it.

Of course, :flashsms => 'yes', still works.

Maybe if the coercion and checking of parameters continue to grow, it should be extracted out of the send method. What do you think?

@mattiassvedhem
Copy link
Contributor Author

Some ruby versions throws the arguments around, need to figure out a better way to mock that request. And also garbage json example fails under ruby-head. In general though, do you want me to keep the cleanup of the specs?

@jage
Copy link
Owner

jage commented Apr 18, 2013

Yeah, the specs really need a cleanup.

jage added a commit that referenced this pull request May 1, 2013
@jage jage merged commit e503407 into jage:master May 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants