Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Config option to disallow external url sources #808

Open
MichailiK opened this issue Sep 15, 2021 Discussed in #744 · 4 comments
Open

[Feature Request] Config option to disallow external url sources #808

MichailiK opened this issue Sep 15, 2021 Discussed in #744 · 4 comments

Comments

@MichailiK
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
LavaPlayer allows playing of any arbitrary URLs, which some are considering as a security issue.

Describe the solution you'd like
A config entry should be added, which allows bot owners to not load tracks from external URL's. YouTube, SoundCloud etc. can still load regardless of this setting

Describe the basic flow/steps of using this feature

    • The bot owner disables the capability of playing from external url sources
    • No one will be able to queue any music outside of YouTube, SoundCloud etc.
    • The bot owner disables the capability of playing from external url sources
    • Everyone will be able to queue any music outside of YouTube, SoundCloud etc.

Additional context
Discussed in #744

Originally posted by hermitoff August 29, 2021
Hello,

Do not use your IP to host the bot!
Because anyone can find it.

You just have to send to the bot a request (with the command play) to an ip logger to get it.

Here is an example to show you:
unknown

I'm sorry to show this to everybody.
And don't worry about the IP on the image, I don't care.

@jagrosh
Copy link
Owner

jagrosh commented Sep 15, 2021

I am currently debating whether this would be better as a standalone feature, or to integrate this into transforms.

@hermitoff
Copy link

It would be better, and simpler, to make a whitelist of allowed URLs?

@KenaiTheWolf
Copy link

Just wondering if this has been implemented? Would it also be possible to make search default away from YouTube if it were disabled in the conf?

@MichailiK
Copy link
Collaborator Author

We close issues once they are fully implemented. This issue is still open, so it has not been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants