Straight shoota sanitizer #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raw HTML is provided by `*_raw` methods. Prefix-free reader methods automatically provide sanitized strings. `MetaInspector::Sanitizer` completely removes possibly dangerous tags such as `<script>` and unknown tags including der content. Safe tags are replaced by their text content. HTML entities are decoded and additional whitespace removed, just as a browser would do (explicit whitespace like in `<pre>` tags are not preserved). This changes behaviour such that the suffix-free methods now provide a properly sanitized strings without unnecessary whitespaces. For sanitizing the gems 'loofah' and 'htmlentities' are added as dependencies.
…de` method and `sanitized_attributes` creates readers `att` and `att_raw`. The latter calls `inner_html` on the return value from node method. Now scrubbing in the sanitizer can use the already existing HTML objects instead of serializing and parsing again.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the work by @straight-shoota in #193 so it's easier to fix conflicts.