Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing generics to API that were missed in Faces 4.0 #1708

Closed
pnicolucci opened this issue Oct 21, 2022 · 1 comment
Closed

Add missing generics to API that were missed in Faces 4.0 #1708

pnicolucci opened this issue Oct 21, 2022 · 1 comment
Labels
mojarra-implemented API issue implemented by Mojarra myfaces-implemented API issue implemented by MyFaces
Milestone

Comments

@pnicolucci
Copy link
Contributor

pnicolucci commented Oct 21, 2022

During MyFaces 4.0 development I opened the following issue that outlines the missing generics: https://issues.apache.org/jira/browse/MYFACES-4454

  1. https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/context/externalcontextwrapper#getInitParameterMap() should have a return type of Map<String,String> The ExternalContext already defines the method in the same way.

  2. https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/render/renderer#getConvertedValue(jakarta.faces.context.FacesContext,jakarta.faces.component.UIComponent,java.lang.Object) should take an argument of T rather than UIComponent This would align with the rest of the methods in the Renderer API.

This was missed when #1497 was completed for Faces 4.0.

@tandraschko tandraschko added this to the 4.1 milestone Nov 15, 2022
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Jul 30, 2023
Add missing generics to API that slipped through in Faces 4.0
@tandraschko tandraschko added the myfaces-implemented API issue implemented by MyFaces label Aug 1, 2023
@BalusC BalusC added the mojarra-implemented API issue implemented by Mojarra label Oct 5, 2023
@BalusC
Copy link
Member

BalusC commented Oct 5, 2023

Implemented in both Mojarra and MyFaces, closing off.

@BalusC BalusC closed this as completed Oct 5, 2023
BalusC added a commit to eclipse-ee4j/mojarra that referenced this issue Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mojarra-implemented API issue implemented by Mojarra myfaces-implemented API issue implemented by MyFaces
Projects
None yet
Development

No branches or pull requests

3 participants