Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK Challenge Spec1IT: f:validateWholeBean placement would be validated better in development mode, not production #1780

Closed
volosied opened this issue Jan 19, 2023 · 4 comments
Labels
accepted Accepted certification request challenge TCK challenge

Comments

@volosied
Copy link
Contributor

volosied commented Jan 19, 2023

Challenged Tests:
ee.jakarta.tck.faces.test.javaee7.multiFieldValidation.Spec1IT#testFailingPreconditionsNotAfterAllInputComponents

TCK Version:
Jakarta Faces 4.0.x

Tested Implementation:
MyFaces 4.0 (MYFACES-4550 -- In Progress)

Description:

This test asserts that f:validateWholeBean is placed after all inputs. If not, it throws an exception is thrown which results in a 500 response.

The documentation specifies:
This tag must be placed in the component tree after all of the fields that are to be included in the multi-field validation. If this precondition is not met, the results of applying this tag are unspecified.

The fix in MyFaces is not yet merged since we have community suggested that this check should only occur when the project stage is in development mode (via jakarta.faces.application.ProjectStage.Development, not production. This seems like a reasonable ask from our perspective, as this placement should be validated during the development phase.

@pnicolucci pnicolucci added the challenge TCK challenge label Jan 19, 2023
@volosied
Copy link
Contributor Author

This test was also affected by the buffer size, which I have a PR for here: #1779

@pnicolucci
Copy link
Contributor

pnicolucci commented Jan 24, 2023

@arjantijms @BalusC what do you think? This seems like a valid request by the MyFaces community. @volosied has created two PRs to address this challenge:

  1. Update faces22/multiFieldValidation's FACELETS_BUFFER_SIZE to 4096 #1779 -> Increase the FACELET_BUFFER_SIZE

  2. Update faces22/multiFieldValidation to use development project stage #1783 -> Set the Project Stage to Development

Any objections to accepting this challenge and merging both of the PRs?

@BalusC
Copy link
Member

BalusC commented Jan 27, 2023

Accepted and both PRs merged.

@pnicolucci pnicolucci added the accepted Accepted certification request label Jan 27, 2023
@pnicolucci
Copy link
Contributor

Added the accepted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted certification request challenge TCK challenge
Projects
None yet
Development

No branches or pull requests

3 participants