-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UUIDConverter #1819
Comments
I remember in the next Jakarta EE plan dicussion doc(Google docs), there is a common placeholder for the future Jakarta. I hope there is a common |
Add UUIDConverter
Register UUIDConverter
Add message translations for de/en/es/pt
I added UUIDConverter for 4.1, cc: @arjantijms Next step: translations of faces messages for following languages which I'm not familiar with:
Any volunteers? :) |
Chinese translation eclipse-ee4j/mojarra#5244 |
Added French translation, unverified, it was a best guess based on existing NumberConverter.PERCENT translation.
Thank you very much! I've merged your Chinese translation into the PR. Then I added a best guess of the French translation. Now only pending:
Translations are not mandatory for the spec btw. It'll in any case fall back to English as default. |
I brought this forward a long time ago: https://arjan-tijms.omnifaces.org/2014/08/high-time-to-standardize-java-ee.html |
@BalusC you could ask ChatGPT to translate, if you ask properly it will respect the properties template ;) |
I'm working on "basic" Converters optimization (I'll create a PR within an hour) I made some tests and I suspect that there are some minor "bugs", For example:
But in this way it does not override the default Faces Converter at runtime. To make it work I also have to declare it inside
In this way it works, in fact if I inspect the class hashcode, the instance is always the same but on Faces side, I don't know if this behavior or other minor bugs are causing or contributing eclipse-ee4j/mojarra#5110 Overall the algorithm is very complex and it is implemented Probably it's time to refactor all the process as @arjantijms said almost 10 years ago |
If the faces converter is managed by CDI, it should be found by CDI bean manager directly, no need register it in |
And |
@hantsy Yes it is exactly what I thought, but if I remove the declaration inside Evenmore, by putting some log inside mojarra's internal algo, I need more time to test this, but I don't know if it's time to because at the end of the day |
For the next version we should probably deprecate declaring inside faces-config.xml and thereafter prune that. The difference in expectations is (I think) on ongoing source of issues and confusion. |
@arjantijms @pizzi80 I have added a UUIDConverter in my jakartaee10-starter-boilerplate, used it directly in the facelets without adding declaration in faces-config.xml, it works on Glassfish 7.0.5. |
UUIDConverter it's not a default basic converter and you are explicitly declaring it in the view Try to override the IntegerConverter without declaring it in the view using the forClass attribute in the java annotation |
any more tasks? implemented in both impls, we could close this one |
Faces should add a default converter for UUID type...till now I have to create an custom for myself.
JPA has already add UUID as basic type and also support it as ID.
Originally posted by @hantsy in #752 (comment)
The text was updated successfully, but these errors were encountered: