Unify ActionSource and ActionSource2

[tandraschko]

anyone knows the history?

[jasondlee]

IIRC, there was a need to extend ActionSource, but changing it directly would break any code that implemented it, so the new interface was created. Since default methods weren't a thing then, anything added to ActionSource would have to be implemented explicitly by impls, so the choice was made to maintain backwards compatibility and create the new interface.

[tandraschko]

thanks!
@BalusC @arjantijms should we deprecate ActionSource2 for 4.1 then and add those methods to ActionSource?

[arjantijms]

@tandraschko yes, sounds like a good plan!

[BalusC]

If there are breaking changes isn't 5.0 a more correct target?

[tandraschko]

I would deprecate in 4.1 and remove 5.0

[tandraschko]

@BalusC i would suggest to add the get/setActionExpression to ActionSource and deprecate ActionSource2

[tandraschko]

are you guys ok with that? i can prototype in MF

[BalusC]

Go ahead. Basically just add new API introduced in ActionSource2 as default methods of ActionSource interface.

[BalusC]

While implementing this I stumbled upon jakarta.faces.view.ActionSource2AttachedObjectHandler and jakarta.faces.view.ActionSource2AttachedObjectTarget, with the unfortunate 2 in the names. And there are no ActionSourceAttachedObjectHandler / ActionSourceAttachedObjectTarget classes so dropping the 2 will definitely be a breaking change on that. We should copy them into ones without 2 in the name and deprecate the originals.

[BalusC]

I created a PR ^^

[tandraschko]

Looks good

[tandraschko]

will start implementing in MF now