-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify ActionSource and ActionSource2 #1832
Comments
IIRC, there was a need to extend ActionSource, but changing it directly would break any code that implemented it, so the new interface was created. Since default methods weren't a thing then, anything added to ActionSource would have to be implemented explicitly by impls, so the choice was made to maintain backwards compatibility and create the new interface. |
thanks! |
@tandraschko yes, sounds like a good plan! |
If there are breaking changes isn't 5.0 a more correct target? |
I would deprecate in 4.1 and remove 5.0 |
@BalusC i would suggest to add the get/setActionExpression to ActionSource and deprecate ActionSource2 |
are you guys ok with that? i can prototype in MF |
Go ahead. Basically just add new API introduced in ActionSource2 as default methods of ActionSource interface. |
While implementing this I stumbled upon |
I created a PR ^^ |
Looks good |
will start implementing in MF now |
anyone knows the history?
The text was updated successfully, but these errors were encountered: