Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases/2.1.0.m1 #27

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Releases/2.1.0.m1 #27

merged 2 commits into from
Jun 1, 2022

Conversation

erdlet
Copy link
Contributor

@erdlet erdlet commented May 31, 2022

Now the correct branch for milestone release. Contains tests for form method overwrite and fixes for CDI usage

@erdlet erdlet requested review from ivargrimstad and chkal May 31, 2022 17:51
@erdlet erdlet self-assigned this May 31, 2022
@erdlet erdlet merged commit 61dd501 into master Jun 1, 2022
@erdlet erdlet deleted the releases/2.1.0.M1 branch June 1, 2022 16:23
@chkal
Copy link
Contributor

chkal commented Jun 4, 2022

@erdlet Did you already run the release job for the tag?

@erdlet
Copy link
Contributor Author

erdlet commented Jun 4, 2022

No sorry. Also I removed the branch by accident, so I need to recreate a release branch bases on the tag

@chkal
Copy link
Contributor

chkal commented Jun 4, 2022

TBH: I don't remember anymore how the releases are performed. Wasn't there a Jenkins job which publishes releases by checking out a tag and building it? In this case having the tag would be fine...

@erdlet
Copy link
Contributor Author

erdlet commented Jun 4, 2022

Thanks to Ivar I'm aware of the procedure. Thought we want to keep the release branch. But maybe this makes only sense for RC and final releases. I'll have a look into it this evening :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants