Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal to fix signatures of operations of entity graphs #425

Closed
wants to merge 1 commit into from
Closed

Proposal to fix signatures of operations of entity graphs #425

wants to merge 1 commit into from

Conversation

gavinking
Copy link
Contributor

This is just a proposal to:

  • fix the (I believe) incorrect signatures of some operations of EntityGraph and SubGraph, and
  • introduce AbstractGraph as a place to declare common operations of EntityGraph and SubGraph.

See #424.

@gavinking
Proposal to fix signatures of operations of entity graphs
9c9dd2d 
Introduces AbstractGraph as a place to declare common operations of EntityGraph and SubGraph

See jakartaee#424
@gavinking gavinking mentioned this pull request Jul 3, 2023
Closed
@lukasj lukasj linked an issue Aug 4, 2023 that may be closed by this pull request
incorrect generic typing in operations of EntityGraph #424
Closed
lukasj
lukasj reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split this work into multiple parts:

  • 1st create Graph interface (instead of AbstractGrapth)/refactor code
  • 2nd PR pr change/additions to review

@gavinking gavinking mentioned this pull request Aug 8, 2023
Merged
@gavinking
Copy link
Contributor Author

superseded by #430

@gavinking gavinking closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect generic typing in operations of EntityGraph
2 participants
@gavinking @lukasj