Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce FindOption interface and new overloads of EM.find() #454

Merged
merged 6 commits into from
Aug 21, 2023

Conversation

gavinking
Copy link
Contributor

@gavinking gavinking commented Aug 11, 2023

Introduces:

  • FindOption interface and new overloads of EM.find()
  • RefreshOption interface and new overloads of EM.refresh()
  • LockOption interface and new overloads of EM.lock()
  • Graph.removeAttributeNode()
  • setCacheStoreMode()/setCacheRetreiveMode() on EntityManager and Query

see #383 and #65. (Also #64.)

Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 5f826c6 into jakartaee:master Aug 21, 2023
3 of 4 checks passed
* Specify a timeout in seconds.
* (Abbreviation of {@link #seconds(int)}.)
*/
public Timeout s(int seconds) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, another oversight - this (and few other methods) should be static, right now there is no way to create/get an instance of the Timeout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG I suck. Sorry.

Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Aug 31, 2023
…erloads of EM.find()

 * implemented public <T> T find(Class<T> entityClass, Object primaryKey, FindOption... options)
 * added FindOption processing for JPA API enums, Timeout class was not added yet

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Aug 31, 2023
…erloads of EM.find()

 * implemented public <T> T find(Class<T> entityClass, Object primaryKey, FindOption... options)
 * added FindOption processing for JPA API enums, Timeout class was not added yet

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Oct 17, 2023
…erloads of EM.find()

 * implemented public <T> T find(Class<T> entityClass, Object primaryKey, FindOption... options)
 * added FindOption processing for JPA API enums, Timeout class was not added yet

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
lukasj pushed a commit to eclipse-ee4j/eclipselink that referenced this pull request Oct 17, 2023
…erloads of EM.find()

 * implemented public <T> T find(Class<T> entityClass, Object primaryKey, FindOption... options)
 * added FindOption processing for JPA API enums, Timeout class was not added yet

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Oct 19, 2023
…erloads of EM.find()

jakartaee/persistence#467 - add joins to entity types (range variables)

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Oct 25, 2023
…erloads of EM.find()

jakartaee/persistence#467 - add joins to entity types (range variables)

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
lukasj pushed a commit to eclipse-ee4j/eclipselink that referenced this pull request Nov 7, 2023
…erloads of EM.find()

jakartaee/persistence#467 - add joins to entity types (range variables)

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 19, 2023
…AttributeType) in Graph

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 21, 2023
…AttributeType) in Graph

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Jan 22, 2024
…AttributeType) in Graph

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants