Compiling for Java 21 #1168
Merged
Compiling for Java 21 #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarg
force-pushed
the
jdk-1167
branch
2 times, most recently
from
047aed0
to
dafe7e9
Compare
arjantijms
approved these changes
Aug 12, 2023
|
Instead of source/target, the release attribute can be used as well. |
chkal
approved these changes
Aug 13, 2023
andymc12
approved these changes
Aug 14, 2023
jamezp
reviewed
Aug 14, 2023
|
Do we want to do this before Java 21 is released? |
This happens solely in the release-4.0 branch, where compiling against 21 is mandatory anyways according to the Jakarta EE 11 release plan. JDK 21 published RC 1 already; according to the JDK rules, the sole difference between now and later is more bug fixes. So why should we wait? What would break that could not get fixed within a single business day (and possibly doesn't care as this is not the master branch)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1167
This PR enables compilation of JDK 21 in the release-4.0 branch as proposed in the discussion of #1167.
As these are no API changes, this is a fast-track review period of just one day as per our committer rules.