Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servlet 6.0.0 release #434

Merged
merged 8 commits into from
Apr 27, 2022

Conversation

markt-asf
Copy link
Contributor

@markt-asf markt-asf commented Nov 23, 2021

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

@netlify
Copy link

netlify bot commented Nov 23, 2021

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit 29480a1
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/62667e318292dc00082a004d
😎 Deploy Preview https://deploy-preview-434--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Nov 23, 2021
@edbratt
Copy link
Contributor

edbratt commented Jan 7, 2022

Could someone please have a look at why the deploy preview for this PR has failed?

@marceloancelmo
Copy link
Contributor

On it @edbratt

@markt-asf markt-asf marked this pull request as ready for review January 27, 2022 18:40
@marceloancelmo marceloancelmo self-requested a review April 6, 2022 14:07
@dblevins
Copy link
Contributor

dblevins commented Apr 6, 2022

@gregw @markt-asf This PR still needs a compatible implementation that passes the TCK. Could we potentially use Jetty or Tomcat or both?

On the Tomcat side, I know there've been some tests we don't agree with. This would be an ideal time to get them potentially excluded and the TCK updated before it goes final.

@markt-asf
Copy link
Contributor Author

I was expecting the CCR to come from Glassfish.

@marceloancelmo
Copy link
Contributor

will check glassfish in this case @markt-asf

@markt-asf
Copy link
Contributor Author

@dblevins see https://www.eclipse.org/lists/servlet-dev/msg00454.html
The view of the Servlet project was not to change the TCK so as things stand Tomcat cannot pass it (and the Tomcat team is fine with that).

@arjantijms
Copy link
Contributor

will check glassfish in this case @markt-asf

GlassFish passes the Servlet 6 TCK indeed. I can do a CCR for sure. I first thought Tomcat wanted to honour of passing first, as most of the work was done there, and GF just used it. But it's perfectly fine for us to the CCR.

@ivargrimstad
Copy link
Member

ivargrimstad commented Apr 19, 2022

Mentor's Spec Review Checklist

  1. Spec PR
  1. _index.md
  1. javadocs
  • Footer contains Eclipse copyright and link to license
  • ESFL license is included, usually as doc-files/speclicense.html
  • no META-INF directory in PR
  • javadocs-jar artifact matches apidocs (optional for this release)
  1. Spec PDF
  • Correct spec title
  • Version number of the form x.y, not x.y.z
  • Correct Eclipse copyright line
  • No DRAFT or SNAPSHOT
  • Correct Logo
  1. Spec HTML
  • Same as PDF
  1. TCK zip file
  • README file (optional for this release)
  • EFTL license file, preferably named LICENSE.md
  • User's Guide (or equivalent documentation)
  • How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
  1. TCK User's Guide (or equivalent documentation)
  • Software requirements listed
  • Installation and configuration described
  • How to run tests
  • Where to file challenges
  1. Compatibility certification request
  • Request follows template
  • SHA-256 fingerprint matches staged TCK zip file
  • Request issue has certification label.
  1. TCK results summary
  • Page is hosted by Compatible Implementation project
  • Includes all information from certification request
  • Summary includes number of tests passed, failed, errors
  • SHA-256 fingerprint matches staged TCK zip file on cert request
  1. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to emo@eclipse.org.
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

  2. Update Jakarta EE API jar

  • Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

@arjantijms
Copy link
Contributor

The CCR: jakartaee/servlet#464

@markt-asf
Copy link
Contributor Author

Just a rebase

@markt-asf
Copy link
Contributor Author

@ivargrimstad I think we are at the point where I can email the PMC and the EMO. Once you confirm that, I'll get those emails sent.

@marceloancelmo
Copy link
Contributor

Looking pretty good @markt-asf.

Let me take a look in everything and cross-check against the checklist

@gregw
Copy link

gregw commented Apr 25, 2022

just a note to let you all that Jetty is some months off passing the Servlet 6.0 TCK. We are taking the opportunity of the cleanup in 6.0 to do the same in jetty itself, so we are in the middle of a major refactor of jetty.... hence me not responding to this issue for some weeks!

See you on the other side!

@marceloancelmo marceloancelmo merged commit b10cb3a into jakartaee:master Apr 27, 2022
@ivargrimstad
Copy link
Member

@marceloancelmo The ballot must be run before merging! Please do a revert, then finalize the checklist and start the ballot.

@marceloancelmo
Copy link
Contributor

Sorry @ivargrimstad , my bad as I merged by accident while doing the checklist. Reverted, checklist finalized and sending the email for the ballot now

@ivargrimstad
Copy link
Member

No worries
When the ballot completes, you just have to revert the revert-merge again and we're fine :)

@marceloancelmo marceloancelmo added ballot Delivered to the Specification Committee for ballot and removed release review Use this label on PRs that are filed for release review labels Apr 27, 2022
@arjantijms
Copy link
Contributor

I think we are at the point where I can email the PMC and the EMO. Once you confirm that, I'll get those emails sent.

I think we can send the emails now. If I'm not mistaken the emails can be send at any time, and not necessarily have to be send when everything is fully perfect here.

@marceloancelmo
Copy link
Contributor

Good point @arjantijms , we can send the emails to PMC and EMO.

@markt-asf may I please ask you to send the emails?

@markt-asf
Copy link
Contributor Author

Done.

@scottmarlow
Copy link
Contributor

@markt-asf please confirm that you do not want one more Servlet TCK to be built with jakartaee/platform-tck#934?

The discussion is on jakartaee/platform-tck#949

@markt-asf
Copy link
Contributor Author

My preference is to merge the PR and rebuild the TCK if @arjantijms is happy to run the TCK again.

@scottmarlow
Copy link
Contributor

My preference is to merge the PR and rebuild the TCK if @arjantijms is happy to run the TCK again.

So we impact the EE 10 schedule if we delay for this change though, so I think we should continue the ballot.

@arjantijms
Copy link
Contributor

Rerunning the TCK is not much of an issue for me, but as it would delay the ballot and we're extremely close to the last deadline, let's leave this test for next time then.

@marceloancelmo
Copy link
Contributor

Agree on leaving TCK rerun for next time.

I will update the ballot with the details about the update on the TCK results. Thank you @arjantijms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ballot Delivered to the Specification Committee for ballot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants