-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Servlet 6.0.0 release #434
Servlet 6.0.0 release #434
Conversation
✅ Deploy Preview for jakartaee-specifications ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Could someone please have a look at why the deploy preview for this PR has failed? |
On it @edbratt |
@gregw @markt-asf This PR still needs a compatible implementation that passes the TCK. Could we potentially use Jetty or Tomcat or both? On the Tomcat side, I know there've been some tests we don't agree with. This would be an ideal time to get them potentially excluded and the TCK updated before it goes final. |
I was expecting the CCR to come from Glassfish. |
will check glassfish in this case @markt-asf |
@dblevins see https://www.eclipse.org/lists/servlet-dev/msg00454.html |
GlassFish passes the Servlet 6 TCK indeed. I can do a CCR for sure. I first thought Tomcat wanted to honour of passing first, as most of the work was done there, and GF just used it. But it's perfectly fine for us to the CCR. |
Mentor's Spec Review Checklist
|
The CCR: jakartaee/servlet#464 |
790858d
to
6fbc4f2
Compare
Just a rebase |
@ivargrimstad I think we are at the point where I can email the PMC and the EMO. Once you confirm that, I'll get those emails sent. |
Looking pretty good @markt-asf. Let me take a look in everything and cross-check against the checklist |
just a note to let you all that Jetty is some months off passing the Servlet 6.0 TCK. We are taking the opportunity of the cleanup in 6.0 to do the same in jetty itself, so we are in the middle of a major refactor of jetty.... hence me not responding to this issue for some weeks! See you on the other side! |
@marceloancelmo The ballot must be run before merging! Please do a revert, then finalize the checklist and start the ballot. |
Sorry @ivargrimstad , my bad as I merged by accident while doing the checklist. Reverted, checklist finalized and sending the email for the ballot now |
No worries |
I think we can send the emails now. If I'm not mistaken the emails can be send at any time, and not necessarily have to be send when everything is fully perfect here. |
Good point @arjantijms , we can send the emails to PMC and EMO. @markt-asf may I please ask you to send the emails? |
Done. |
@markt-asf please confirm that you do not want one more Servlet TCK to be built with jakartaee/platform-tck#934? The discussion is on jakartaee/platform-tck#949 |
My preference is to merge the PR and rebuild the TCK if @arjantijms is happy to run the TCK again. |
So we impact the EE 10 schedule if we delay for this change though, so I think we should continue the ballot. |
Rerunning the TCK is not much of an issue for me, but as it would delay the ballot and we're extremely close to the last deadline, let's leave this test for next time then. |
Agree on leaving TCK rerun for next time. I will update the ballot with the details about the update on the TCK results. Thank you @arjantijms |
Specification PR template
When creating a specification project release review, create PRs with the content defined as follows.
Include the following in the PR:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
Instructions MAY be by reference.
https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/servlet/jakarta.servlet-api/6.0.0/
https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-servlet-tck-6.0.0.zip
Compatibility certification request for EE4J implementation of Jakarta Servlet 6 servlet#464
If desired, an optional second PR can be created to contain just the JavaDoc in the
apidocs
directory.Note: If any item does not apply, check it and mark N/A below it.