Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta JSON Binding 3.0 spec #456

Merged
merged 5 commits into from
Mar 18, 2022

Conversation

Verdent
Copy link
Contributor

@Verdent Verdent commented Feb 21, 2022

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent Verdent marked this pull request as draft February 21, 2022 13:37
@Verdent Verdent changed the title JSON-B API 3.0 release preparation Jakarta JSON Binding 3.0 spec Feb 21, 2022
@netlify
Copy link

netlify bot commented Feb 21, 2022

✔️ Deploy Preview for jakartaee-specifications ready!

🔨 Explore the source changes: 42287b2

🔍 Inspect the deploy log: https://app.netlify.com/sites/jakartaee-specifications/deploys/62178095794a8e0008e95924

😎 Browse the preview: https://deploy-preview-456--jakartaee-specifications.netlify.app

Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
@ivargrimstad ivargrimstad self-requested a review February 23, 2022 12:02
@ivargrimstad ivargrimstad self-assigned this Feb 23, 2022
@ivargrimstad
Copy link
Member

ivargrimstad commented Feb 23, 2022

Spec Review Checklist (for Mentor)

  1. Spec PR
  1. _index.md
  1. javadocs
  • Footer contains Eclipse copyright and link to license
  • ESFL license is included, usually as doc-files/speclicense.html
  • no META-INF directory in PR
  • javadocs-jar artifact matches apidocs (optional for this release)
  1. Spec PDF
  • Correct spec title
  • Version number of the form x.y, not x.y.z
  • Correct Eclipse copyright line
  • No DRAFT or SNAPSHOT
  • Correct Logo
  1. Spec HTML
  • Same as PDF
  1. TCK zip file
  • N/A README file (optional for this release)
  • EFTL license file, preferably named LICENSE.md
  • User's Guide (or equivalent documentation)
  • How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)
  1. TCK User's Guide (or equivalent documentation)
  • Software requirements listed
  • Installation and configuration described
  • How to run tests
  • Where to file challenges
  1. Compatibility certification request
  • Request follows template
  • SHA-256 fingerprint matches staged TCK zip file
  • Request issue has certification label.
  1. TCK results summary
  • Page is hosted by Compatible Implementation project
  • Includes all information from certification request
  • Summary includes number of tests passed, failed, errors
  • SHA-256 fingerprint matches staged TCK zip file on cert request
  1. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to emo@eclipse.org.
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

  2. Update Jakarta EE API jar

  • Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Feb 23, 2022
Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent Verdent marked this pull request as ready for review February 28, 2022 12:07
@ivargrimstad ivargrimstad added the ballot Delivered to the Specification Committee for ballot label Mar 1, 2022
@ivargrimstad ivargrimstad added complete All specification tasks for release are complete and removed ballot Delivered to the Specification Committee for ballot labels Mar 18, 2022
@ivargrimstad
Copy link
Member

ivargrimstad commented Mar 18, 2022

  • On ballot completion, the specification committee mentor:
  • adds this final checklist to the main PR.
  • adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
  • calculates the staged EFTL TCK signature and promotes it to the committee download area
    using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
  • merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
  • updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
  • notifies the EMO of the ballot results by email to emo@eclipse-foundation.org. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
  • creates an issue in the specification project that includes the following checklist for the specification project team: Finalize Jakarta JSON Binding 3.0 Release jsonb-api#324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complete All specification tasks for release are complete release review Use this label on PRs that are filed for release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants