-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
objectStoreNames
's type seems wrong
#101
Comments
Good point. Ugh, fixing this isn't totally easy, as (fwiw, in Edge, it does return an array, as this property is polyfilled. However I don't know how much I care about this difference, as I intend to remove EdgeHTML support in the next major version) |
I'd be interested in submitted a PR for this if @jakearchibald hasn't worked on it yet 😄. |
Go for it! |
Add typed version of DOMStringList Fixes jakearchibald#101
* Change `objectStoreNames` to DOMStringList Add typed version of DOMStringList Fixes #101 * Remove duplicate property
I think there's still an issue with Line 531 in abce3c7
It is array like, rather than DOMStringList. Just got burnt by this in a migration where I used |
I'll fix this tomorrow |
Fix published as 6.1.4. |
Woohoo pipeline fixed, thanks! |
idb/lib/entry.ts
Line 149 in 809a75c
As far as I can tell, within my browser, this method returns a
DOMStringList
, which is not an array.In particular, it contains a method
contains
, and does not contain array methods such asindexOf
, which leads to both static and run-time errors.The text was updated successfully, but these errors were encountered: