Isomorphic imports 2 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isomorphic imports
… into isomorphic-imports-2
| @@ -0,0 +1,5 @@ | |||
| module.exports = { | |||
| idb: function () { | |||
There was a problem hiding this comment.
idb is a function here, but in the browser version it's an object with two methods.
|
This looks good to me! Going to bump the main version for this in case it breaks things with particular importers. |
|
This has caused #33 - not all node.js environments should reject idb - Electron, Atom and anything else with access to a browser window should have a specific check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specify main and browser fields in package.json
https://github.com/defunctzombie/package-browser-field-spec/blob/master/README.md
main exports function that returns undefined
browser exports idb
alternative to this pull request: #18
and fixes this issue: #17
You can test in this project:
https://github.com/noahehall/react-f-your-starterkit
$ npm install
$ npm run dev > test on 127.0.0.1:3000
$ npm run prod > test on https://localhost:3000